Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver: add some additional test coverage #2030

Merged
merged 1 commit into from
Dec 29, 2024
Merged

resolver: add some additional test coverage #2030

merged 1 commit into from
Dec 29, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 29, 2024

While here, remove some code paths that do not occur by definition. (For example, if the resolver succeeds, we will definitely have a valid set of addresses, but if it fails, we will definitely not.)

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

While here, remove some code paths that do not occur by definition.
(For example, if the resolver succeeds, we will definitely have a
valid set of addresses, but if it fails, we will definitely not.)
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (a1bc59a) to head (b5462f6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/platform/posix/posix_resolv_gai.c 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2030      +/-   ##
==========================================
+ Coverage   82.55%   82.69%   +0.13%     
==========================================
  Files          95       95              
  Lines       23662    23656       -6     
  Branches     3046     3044       -2     
==========================================
+ Hits        19534    19562      +28     
+ Misses       4058     4023      -35     
- Partials       70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit b5462f6 into main Dec 29, 2024
35 of 36 checks passed
@gdamore gdamore deleted the resolv-tests branch December 29, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant