Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project config #61

Merged
merged 1 commit into from
May 15, 2024
Merged

Update project config #61

merged 1 commit into from
May 15, 2024

Conversation

nao1215
Copy link
Owner

@nao1215 nao1215 commented May 15, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a template for submitting feature requests.
    • Added guidelines for contributing to the project in the new CONTRIBUTING.md file.
  • Bug Fixes

    • Updated the bug report template to streamline the title format.
  • Documentation

    • Updated README.md to remove outdated badges and direct users to the new CONTRIBUTING.md for contribution guidelines.
    • Added release notes to CHANGELOG.md for recent versions.
  • Chores

    • Renamed and simplified the workflow for running tests with coverage reports.
    • Introduced a new multi-platform unit testing workflow.

Copy link
Contributor

coderabbitai bot commented May 15, 2024

Walkthrough

The recent updates introduce new templates for bug reports and feature requests, enhance workflow automation for coverage and unit testing across multiple platforms, and provide clear guidelines for contributing to the project. Additionally, the README has been refined to remove outdated badges and direct contributors to the new guidelines.

Changes

File/Path Change Summary
.github/ISSUE_TEMPLATE/bug_report.md Modified the title field in the bug report template from "[BUG] XXX" to "[BUG] ".
.github/ISSUE_TEMPLATE/feature-request.md Introduced a new template for submitting feature requests.
.github/workflows/coverage.yml Renamed workflow from "LinuxUnitTest" to "Coverage" and simplified test coverage steps.
.github/workflows/unit_test.yml Added a new workflow for multi-platform unit testing with a matrix strategy for OS and Go versions.
CHANGELOG.md Documented changes including SQLite3 driver update, Excel support, numerical sorting, and more.
CONTRIBUTING.md Added new guidelines for contributing to the project, both for developers and non-coding supporters.
README.md Removed outdated test badges and updated contribution message to refer to the new CONTRIBUTING.md file.

In the garden of code, where changes bloom,
Templates and workflows find their room.
Contributions guided, clear and bright,
Across platforms, tests take flight.
With every update, the project grows,
Thanks to each coder, the garden glows. 🌸🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Code Metrics Report

main (c77e4d9) #61 (57ac3bc) +/-
Coverage 83.9% 83.9% 0.0%
Test Execution Time 52s 2s -50s
Details
  |                     | main (c77e4d9) | #61 (57ac3bc) | +/-  |
  |---------------------|----------------|---------------|------|
  | Coverage            |          83.9% |         83.9% | 0.0% |
  |   Files             |             38 |            38 |    0 |
  |   Lines             |            948 |           948 |    0 |
  |   Covered           |            795 |           795 |    0 |
+ | Test Execution Time |            52s |            2s | -50s |

Reported by octocov

@nao1215 nao1215 merged commit 6ac0196 into main May 15, 2024
15 checks passed
@nao1215
Copy link
Owner Author

nao1215 commented May 15, 2024

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented May 15, 2024

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 13

Out of diff range and nitpick comments (38)
.github/ISSUE_TEMPLATE/bug_report.md (3)

Line range hint 15-15: Lists should be surrounded by blank lines for better readability.

15a16
+

Line range hint 27-29: Unordered list items should be properly indented for consistency.

- **Desktop (please complete the following information):**
-  - OS: [e.g. Ubuntu]
-  - Go Version [e.g. 1.17]
-  - Application Version [e.g. 1.0.1]
+ **Desktop (please complete the following information):**
+ - OS: [e.g. Ubuntu]
+ - Go Version [e.g. 1.17]
+ - Application Version [e.g. 1.0.1]

Line range hint 27-27: Lists should be surrounded by blank lines for better readability.

27a28
+
README.md (34)

Line range hint 19-19: Headings should be surrounded by blank lines for better readability.

19a20
+

Line range hint 20-20: Headings should be surrounded by blank lines for better readability.

20a21
+

Line range hint 25-25: Headings should be surrounded by blank lines for better readability.

25a26
+

Line range hint 30-30: Headings should be surrounded by blank lines for better readability.

30a31
+

Line range hint 35-35: Headings should be surrounded by blank lines for better readability.

35a36
+

Line range hint 40-40: Headings should be surrounded by blank lines for better readability.

40a41
+

Line range hint 61-61: Headings should be surrounded by blank lines for better readability.

61a62
+

Line range hint 75-75: Headings should be surrounded by blank lines for better readability.

75a76
+

Line range hint 113-113: Headings should be surrounded by blank lines for better readability.

113a114
+

Line range hint 120-120: Headings should be surrounded by blank lines for better readability.

120a121
+

Line range hint 121-121: Headings should be surrounded by blank lines for better readability.

121a122
+

Line range hint 135-135: Headings should be surrounded by blank lines for better readability.

135a136
+

Line range hint 151-151: Headings should be surrounded by blank lines for better readability.

151a152
+

Line range hint 164-164: Headings should be surrounded by blank lines for better readability.

164a165
+

Line range hint 173-173: Headings should be surrounded by blank lines for better readability.

173a174
+

Line range hint 183-183: Headings should be surrounded by blank lines for better readability.

183a184
+

Line range hint 188-188: Headings should be surrounded by blank lines for better readability.

188a189
+

Line range hint 193-193: Headings should be surrounded by blank lines for better readability.

193a194
+

Line range hint 21-21: Fenced code blocks should be surrounded by blank lines for better readability.

21a22
+

Line range hint 26-26: Fenced code blocks should be surrounded by blank lines for better readability.

26a27
+

Line range hint 41-41: Fenced code blocks should be surrounded by blank lines for better readability.

41a42
+

Line range hint 123-123: Fenced code blocks should be surrounded by blank lines for better readability.

123a124
+

Line range hint 154-154: Fenced code blocks should be surrounded by blank lines for better readability.

154a155
+

Line range hint 31-31: Lists should be surrounded by blank lines for better readability.

31a32
+

Line range hint 77-77: Lists should be surrounded by blank lines for better readability.

77a78
+

Line range hint 174-174: Lists should be surrounded by blank lines for better readability.

174a175
+

Line range hint 121-121: Trailing spaces should be removed for better formatting.

-![GitHub](https://img.shields.io/github/license/nao1215/sqly)  
+![GitHub](https://img.shields.io/github/license/nao1215/sqly)

Line range hint 153-153: Trailing spaces should be removed for better formatting.

-  - Ctrl + A	|Go to the beginning of the line (Home)|
+  - Ctrl + A |Go to the beginning of the line (Home)|

Line range hint 160-160: Trailing spaces should be removed for better formatting.

-  - Ctrl + L	|Clear the screen|  
+  - Ctrl + L |Clear the screen|

Line range hint 136-149: Hard tabs should be replaced with spaces for better formatting.

-	|Ctrl + A	|Go to the beginning of the line (Home)|
-	|Ctrl + E	|Go to the end of the line (End)|
-	|Ctrl + P	|Previous command (Up arrow)|
-	|Ctrl + N	|Next command (Down arrow)|
-	|Ctrl + F	|Forward one character|
-	|Ctrl + B	|Backward one character|
-	|Ctrl + D	|Delete character under the cursor|
-	|Ctrl + H	|Delete character before the cursor (Backspace)|
-	|Ctrl + W	|Cut the word before the cursor to the clipboard|
-	|Ctrl + K	|Cut the line after the cursor to the clipboard|
-	|Ctrl + U	|Cut the line before the cursor to the clipboard|
-	|Ctrl + L	|Clear the screen|  
+  |Ctrl + A |Go to the beginning of the line (Home)|
+  |Ctrl + E |Go to the end of the line (End)|
+  |Ctrl + P |Previous command (Up arrow)|
+  |Ctrl + N |Next command (Down arrow)|
+  |Ctrl + F |Forward one character|
+  |Ctrl + B |Backward one character|
+  |Ctrl + D |Delete character under the cursor|
+  |Ctrl + H |Delete character before the cursor (Backspace)|
+  |Ctrl + W |Cut the word before the cursor to the clipboard|
+  |Ctrl + K |Cut the line after the cursor to the clipboard|
+  |Ctrl + U |Cut the line before the cursor to the clipboard|
+  |Ctrl + L |Clear the screen|

Line range hint 163-163: Multiple consecutive blank lines should be reduced to a single blank line.

163d164
-

Line range hint 172-172: Multiple consecutive blank lines should be reduced to a single blank line.

172d173
-

Line range hint 124-124: Dollar signs should be removed from commands when not showing output.

-```shell
-$ sqly --sql "SELECT * FROM user LIMIT 2" --csv testdata/user.csv 
+```shell
+sqly --sql "SELECT * FROM user LIMIT 2" --csv testdata/user.csv 

Line range hint 132-132: Dollar signs should be removed from commands when not showing output.

-```shell
-$ sqly --sql "SELECT * FROM user LIMIT 2" --json testdata/user.csv 
+```shell
+sqly --sql "SELECT * FROM user LIMIT 2" --json testdata/user.csv 
CHANGELOG.md (1)

Line range hint 133-133: Multiple consecutive blank lines should be reduced to a single blank line.

133d134
-
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c77e4d9 and 30df246.
Files ignored due to path filters (1)
  • doc/img/cover-tree.svg is excluded by !**/*.svg
Files selected for processing (7)
  • .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
  • .github/ISSUE_TEMPLATE/feature-request.md (1 hunks)
  • .github/workflows/coverage.yml (2 hunks)
  • .github/workflows/unit_test.yml (1 hunks)
  • CHANGELOG.md (1 hunks)
  • CONTRIBUTING.md (1 hunks)
  • README.md (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/coverage.yml
Additional comments not posted (1)
.github/workflows/unit_test.yml (1)

1-36: The multi-platform unit test workflow is well-structured and complete. LGTM!

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature-request.md Show resolved Hide resolved
README.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant