This repository has been archived by the owner on Sep 17, 2019. It is now read-only.
Added AttributeError Exception to __del__ function in NetworkDriver #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarrosop
reviewed
Jul 1, 2017
napalm_base/base.py
Outdated
| @@ -68,6 +68,8 @@ def __del__(self): | |||
| try: | |||
| if self.is_alive()["is_alive"]: | |||
| self.close() | |||
| except AttributeError: | |||
There was a problem hiding this comment.
As this is triggered only when deleting the object I think it's actually safer to just capture all the exceptions. Would you mind replacing both except clauses with just one?
try:
if self.is_alive()["is_alive"]:
self.close()
except Exception:
pass
|
Yes I agree with you. I have modified that code. |
|
Thanks! |
|
Fixes #267 |
dbarrosop
added a commit
that referenced
this pull request
Jul 3, 2017
* Fix mac address format * Documentation: Fix example mac addresses to be proper form * Correctly check all keys comply (#266) * Improve coverage of get_network_driver() (#263) * Improve coverage of get_network_driver * Revert import of napalm_logs for tests * Driver prepending optional * Test more branches in get_network_driver * Added AttributeError Exception to __del__ function in NetworkDriver (#268) * Added AttributeError Exception to __del__ function in NetworkDriver class * Added AttributeError Exception to __del__ function in NetworkDriver * Dumb driver (#269) * Context manager propagates exceptions properly * Implemented generic mock driver * Add possibility to raise Exceptions on demand * Mock cli commands individually * Map junos' _rpc to cli * Mocking configuration management methods * Added tests for configuration methods * Bump version to 0.24.2 (#270)
bewing
added a commit
to bewing/napalm-base
that referenced
this pull request
Jul 18, 2017
…to tox * 'develop' of github.com:napalm-automation/napalm-base: Bump version to 0.24.3 (napalm-automation#275) Validate string before evaluating (napalm-automation#274) Bump version to 0.24.2 (napalm-automation#270) Dumb driver (napalm-automation#269) Added AttributeError Exception to __del__ function in NetworkDriver (napalm-automation#268) Improve coverage of get_network_driver() (napalm-automation#263)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes Issue #267:
https://github.com/napalm-automation/napalm-base/issues/267
Adding an exception handler for AttributeError allows the script to complete.