Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLDP interface showing with quotes #1153

Closed
inetman28 opened this issue Mar 20, 2020 · 7 comments · Fixed by #1175
Closed

LLDP interface showing with quotes #1153

inetman28 opened this issue Mar 20, 2020 · 7 comments · Fixed by #1175

Comments

@inetman28
Copy link

Environment

  • Python version: 3.6.8
  • NetBox version: 2.7.8
  • Napalm version: 2.3.3 and 2.5.0

Steps to Reproduce

  1. Use driver EOS and method get_lldp_neighbors_detail

Expected Behavior

Napalm return me correct key value pair without quotes

Observed Behavior

As you can see remote_port key have value with quotation marks (see below):

         "Ethernet49/1": [
            {
                "parent_interface": "Ethernet49/1",
                "remote_port": "\"Ethernet49/1\"",  
                "remote_port_description": "SOMETHING DESCRIPTION",
                "remote_system_name": "DC1-SW4",
                "remote_system_description": "Arista Networks EOS version 4.22.3M running on an Arista Networks DCS-7060SX2-48YC6",
                "remote_chassis_id": "98:5D:82:62:BD:ВВ",
                "remote_system_capab": [
                    "bridge",
                    "router"
                ],
                "remote_system_enable_capab": [
                    "bridge",
                    "router"
                ]
            }
        ],

@mirceaulinic
Copy link
Member

I don't know if I should laugh or cry (or both). Thanks for reporting @inetman28.

@TheRealBecks
Copy link
Contributor

TheRealBecks commented Mar 27, 2020

@inetman28 That's not a NAPALM bug, because when you issue "show lldp neighbors detail | json" on an Arista switch you will see that the doubled quotation marks come from there. Here's my example output:
"interfaceId": "\"Gi0/8\"",
On Cisco NX-OS 7 the output is as follows:
"port_id": "Gi0/4"
So it looks like a wrong output on EOS? Maybe you should file a bug report to Arista?

@inetman28
Copy link
Author

I create support request to support@arista.com (via email).

@mirceaulinic
Copy link
Member

I agree, and encourage you to open a case with Arista, however I believe we should correct this on the NAPALM side as well (for regression, moving forward). CC @TheRealBecks @inetman28

@mirceaulinic
Copy link
Member

Could any of you test #1175 and confirm it works as expected?

@TheRealBecks
Copy link
Contributor

@mirceaulinic That fixes the problem, thanks!

@asergeant01
Copy link

I have it that this will be addressed by Arista.....

LLDP thing is fixed under Bug 480042 so it should start making it to releases in the next few weeks
One caveat though is that to preserve existing behaviour (to stop changes from potentially breaking existing automation deployments) we are adding "interfaceId_v2": "Ethernet1 rather then changing interfaceId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants