Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Vlan interfaces nxos driver, the state is not correctly defined (related to json output). #1072

Merged
merged 8 commits into from
Oct 28, 2019

Conversation

VictorPavlushin
Copy link
Contributor

For Vlan interfaces nxos driver, the state is not correctly defined (related to json output).

There are no admin_state and state fields for them.
Example:
{
"interface": "Vlan120",
"svi_admin_state": "up",
"svi_line_proto": "up",
"svi_mac": "002a.6ad3.0000",
"svi_desc": "",
"svi_ip_addr": "192.168.0.10",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},
{
"interface": "Vlan198",
"svi_admin_state": "down",
"state_rsn_desc": "Administratively down",
"svi_line_proto": "down",
"svi_mac": "002a.6ad3.0000",
"svi_ip_addr": "192.168.0.11",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},

…related to json output).

There are no admin_state and state fields for them.
Example:
{
"interface": "Vlan120",
"svi_admin_state": "up",
"svi_line_proto": "up",
"svi_mac": "002a.6ad3.0000",
"svi_desc": "",
"svi_ip_addr": "192.168.0.10",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},
{
"interface": "Vlan198",
"svi_admin_state": "down",
"state_rsn_desc": "Administratively down",
"svi_line_proto": "down",
"svi_mac": "002a.6ad3.0000",
"svi_ip_addr": "192.168.0.11",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},
@coveralls
Copy link

coveralls commented Oct 22, 2019

Coverage Status

Coverage decreased (-0.02%) to 81.31% when pulling ec03e29 on VictorPavlushin:Vlan_interface into f9c8ae1 on napalm-automation:develop.

Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @VictorPavlushin!

@mirceaulinic mirceaulinic added this to the 3.0.0 milestone Oct 28, 2019
@mirceaulinic mirceaulinic merged commit 6709e1c into napalm-automation:develop Oct 28, 2019
@VictorPavlushin VictorPavlushin deleted the Vlan_interface branch October 29, 2019 01:59
ExaneServerTeam pushed a commit to ExaneServerTeam/napalm that referenced this pull request Mar 6, 2020
…related to json output). (napalm-automation#1072)

* For Vlan interfaces nxos driver, the state is not correctly defined (related to json output).
There are no admin_state and state fields for them.
Example:
{
"interface": "Vlan120",
"svi_admin_state": "up",
"svi_line_proto": "up",
"svi_mac": "002a.6ad3.0000",
"svi_desc": "",
"svi_ip_addr": "192.168.0.10",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},
{
"interface": "Vlan198",
"svi_admin_state": "down",
"state_rsn_desc": "Administratively down",
"svi_line_proto": "down",
"svi_mac": "002a.6ad3.0000",
"svi_ip_addr": "192.168.0.11",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},

* misprint

* Because this is a virtual interface, then is_up == is_enabled, from my point of view.

* black test

* misprint

* I have extra characters on some devices

* Removed debug output
neelimapp pushed a commit to neelimapp/napalm that referenced this pull request Mar 20, 2020
…related to json output). (napalm-automation#1072)

* For Vlan interfaces nxos driver, the state is not correctly defined (related to json output).
There are no admin_state and state fields for them.
Example:
{
"interface": "Vlan120",
"svi_admin_state": "up",
"svi_line_proto": "up",
"svi_mac": "002a.6ad3.0000",
"svi_desc": "",
"svi_ip_addr": "192.168.0.10",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},
{
"interface": "Vlan198",
"svi_admin_state": "down",
"state_rsn_desc": "Administratively down",
"svi_line_proto": "down",
"svi_mac": "002a.6ad3.0000",
"svi_ip_addr": "192.168.0.11",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},

* misprint

* Because this is a virtual interface, then is_up == is_enabled, from my point of view.

* black test

* misprint

* I have extra characters on some devices

* Removed debug output
bharath-ravindranath pushed a commit to bharath-ravindranath/napalm that referenced this pull request Apr 19, 2020
…related to json output). (napalm-automation#1072)

* For Vlan interfaces nxos driver, the state is not correctly defined (related to json output).
There are no admin_state and state fields for them.
Example:
{
"interface": "Vlan120",
"svi_admin_state": "up",
"svi_line_proto": "up",
"svi_mac": "002a.6ad3.0000",
"svi_desc": "",
"svi_ip_addr": "192.168.0.10",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},
{
"interface": "Vlan198",
"svi_admin_state": "down",
"state_rsn_desc": "Administratively down",
"svi_line_proto": "down",
"svi_mac": "002a.6ad3.0000",
"svi_ip_addr": "192.168.0.11",
"svi_ip_mask": "24",
"svi_mtu": "1500",
"svi_bw": "1000000",
"svi_delay": "10"
},

* misprint

* Because this is a virtual interface, then is_up == is_enabled, from my point of view.

* black test

* misprint

* I have extra characters on some devices

* Removed debug output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants