Prevent nxos.get_interfaces_ip from failing if no ipv6 support #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cisco Nexus 3548's still don't support ipv6, so catch the NXAPIPostError exception when `get_interfaces_ip` tries to run `show ipv6 interfaces` and return the ipv4 addresses
mirceaulinic
approved these changes
Jan 18, 2020
There was a problem hiding this comment.
Thanks for this patch @tcaiazza. Would you please add a test case for this?
@mirceaulinic Test case added. |
1 task
neelimapp
pushed a commit
to neelimapp/napalm
that referenced
this pull request
Mar 20, 2020
…m-automation#1108) * Prevent nxos.get_interfaces_ip from failing if no ipv6 support Cisco Nexus 3548's still don't support ipv6, so catch the NXAPIPostError exception when `get_interfaces_ip` tries to run `show ipv6 interfaces` and return the ipv4 addresses * Add test for no ipv6 support
bharath-ravindranath
pushed a commit
to bharath-ravindranath/napalm
that referenced
this pull request
Apr 19, 2020
…m-automation#1108) * Prevent nxos.get_interfaces_ip from failing if no ipv6 support Cisco Nexus 3548's still don't support ipv6, so catch the NXAPIPostError exception when `get_interfaces_ip` tries to run `show ipv6 interfaces` and return the ipv4 addresses * Add test for no ipv6 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cisco Nexus 3548's still don't support ipv6, so catch the NXAPIPostError
exception when
get_interfaces_iptries to runshow ipv6 interfacesand return the ipv4 addresses