Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in traceroute() #1148

Closed
wants to merge 2 commits into from
Closed

Fix typo in traceroute() #1148

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2020

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 82f2de8 on remingu:fix-typo-in-traceroute() into f84a303 on napalm-automation:develop.

Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI seems unhappy due to this change, as the mocked data should now be provided under a different path - see https://travis-ci.org/github/napalm-automation/napalm/jobs/661723387#L865.

@mirceaulinic
Copy link
Member

Bump @remingu

mirceaulinic added a commit that referenced this pull request Apr 14, 2020
@mirceaulinic
Copy link
Member

@remingu wanted to push a commit with the mock file rename, but I couldn't find the branch where you had these changes in our NAPALM clone. Opened #1174 with your changes (although I couldn't pick your commit for the same reasoning above).

mirceaulinic added a commit that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants