Use aply-groups inheritance on get-configuration RPC calls #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behaviour for get-configuration RPC calls has been changed in 2af90cc, in order to ensure we're gathering from the right database. The way junos-eznc works is that if there aren't any specific options passed in, it uses apply-groups by default. But when there are options passed in, as we do starting with 2af90cc, it doesn't default the values of `inherit` and `groups`, and therefore when gathering the config it won't expand the apply-groups, see https://github.com/Juniper/py-junos-eznc/blob/ab0e8603eac56fa1d049695c7ef86eb64582ab8f/lib/jnpr/junos/factory/cfgtable.py#L517-L520. Changing this now, by adding a few new optional arguments, which allow the user to select the desired behaviour.
|
@mirceaulinic tested this against our devices which had the issue reported in #1359 and they now work as expected! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour for get-configuration RPC calls has been changed in
2af90cc, in order to ensure we're gathering from the right database.
The way junos-eznc works is that if there aren't any specific options
passed in, it uses apply-groups by default. But when there are options
passed in, as we do starting with 2af90cc, it doesn't default the
values of
inheritandgroups, and therefore when gathering theconfig it won't expand the apply-groups, see
https://github.com/Juniper/py-junos-eznc/blob/ab0e8603eac56fa1d049695c7ef86eb64582ab8f/lib/jnpr/junos/factory/cfgtable.py#L517-L520.
Changing this now, by adding a few new optional arguments, which allow
the user to select the desired behaviour.