Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_interfaces_ip for non ipv6 devices #627

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

ogenstad
Copy link
Contributor

There's a bug when running against devices which output:
% Invalid input detected at '^' marker.

When running the "show ipv6 interface command"

The current get_interfaces_ip would result in:

{
"Vlan20": {
"ipv4": {
"172.29.50.3": {
"prefix_length": 27
}
}
},
"Vlan41": {
"ipv4": {
"172.29.52.34": {
"prefix_length": 27
},
"192.168.81.34": {
"prefix_length": 24
}
}
},
"^": {
"ipv6": {}
},
"%": {
"ipv6": {}
}
}

There's a bug when running against devices which output:
% Invalid input detected at '^' marker.

When running the "show ipv6 interface command"

The current get_interfaces_ip would result in:

{
	"Vlan20": {
		"ipv4": {
			"172.29.50.3": {
				"prefix_length": 27
			}
		}
	},
	"Vlan41": {
		"ipv4": {
			"172.29.52.34": {
				"prefix_length": 27
			},
			"192.168.81.34": {
				"prefix_length": 24
			}
		}
	},
	"^": {
		"ipv6": {}
	},
	"%": {
		"ipv6": {}
	}
}
@coveralls
Copy link

coveralls commented Jan 19, 2018

Coverage Status

Coverage increased (+0.003%) to 78.921% when pulling 184e275 on ogenstad:ipv6_interfaces into 85610c9 on napalm-automation:develop.

@dbarrosop dbarrosop self-requested a review January 22, 2018 08:42
@dbarrosop dbarrosop merged commit cb5fbd8 into napalm-automation:develop Jan 23, 2018
@ogenstad ogenstad deleted the ipv6_interfaces branch January 23, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants