-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for disable of Junos Locking so that it can be externally managed #881
Conversation
@borisovano I think this is identical to what you implemented (as far as operation). Let me know if you see any issues. @mirceaulinic Let me know if this looks good. I fixed a couple of rebase issues that were in the previous PR. |
napalm/junos/junos.py
Outdated
self.keepalive = optional_args.get("keepalive", 30) | ||
self.ssh_config_file = optional_args.get("ssh_config_file", None) | ||
self.ignore_warning = optional_args.get("ignore_warning", False) | ||
self.port = optional_args.get('port', 22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look reordered after resolving the conflicts with the develop branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, that was mostly just black wanted the strings to be double quoted and the original code had them as single quoted (i.e. the code from the merge conflict). I fixed it so it was compliant with black requirements.
No description provided.