Allow for disable of Junos Locking so that it can be externally managed #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@borisovano I think this is identical to what you implemented (as far as operation). Let me know if you see any issues. @mirceaulinic Let me know if this looks good. I fixed a couple of rebase issues that were in the previous PR. |
mirceaulinic
approved these changes
Dec 19, 2018
napalm/junos/junos.py
Outdated
| self.keepalive = optional_args.get("keepalive", 30) | ||
| self.ssh_config_file = optional_args.get("ssh_config_file", None) | ||
| self.ignore_warning = optional_args.get("ignore_warning", False) | ||
| self.port = optional_args.get('port', 22) |
There was a problem hiding this comment.
These look reordered after resolving the conflicts with the develop branch.
There was a problem hiding this comment.
Okay, that was mostly just black wanted the strings to be double quoted and the original code had them as single quoted (i.e. the code from the merge conflict). I fixed it so it was compliant with black requirements.
ExaneServerTeam
pushed a commit
to ExaneServerTeam/napalm
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.