Catch ValueError exception when vlan is not set to an integer. #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktbyers
requested changes
Dec 20, 2018
napalm/nxos/nxos.py
Outdated
| try: | ||
| vlan = int(mac_entry.get('disp_vlan')) | ||
| except ValueError: | ||
| vlan = '-' |
There was a problem hiding this comment.
VLAN always needs to be an integer...so you should change the vlan assignment in the exception clause to:
except ValueError:
vlan = 0
Also change the quotes around 'disp_vlan' to be double quotes: "disp_vlan" (so that it is compliant with python-black-formatting.
There was a problem hiding this comment.
Thanks for the review & guidance.
o Double quotes around disp_vlan o Changed default vlan value to 0 in exception clause
ktbyers
approved these changes
Dec 23, 2018
ExaneServerTeam
pushed a commit
to ExaneServerTeam/napalm
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vlan is not set to an integer it is set to '-' which causes int() to throw a ValueError exception. Adding try/except around int().