Update example plugin for changes in napari/master, add CI #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
changed the title
Czaki
added a commit
that referenced
this pull request
Apr 8, 2024
* introduce shorter timeout in test.yml * add information on CI timout to README.md (#2) add information on CI timeout to README.md * undo wrong change in test.yml * include short timeout for GH actions this avoids using large amounts of CI time when playing with a plugin draft. * Update .github/workflows/test.yml * Update {{cookiecutter.plugin_name}}/.github/workflows/test_and_deploy.yml * fix additional enter --------- Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the example in
napari_{{cookiecutter.module_name}}.pyfor napari/napari#937Specifically: I removed all napari imports (which is probably best practice), instead choosing to import the
@hook_implementationmarker frompluggyand typings fromtyping.Though the focus of this cookiecutter is more on package structure (as opposed to reader plugin implementations), I also added many more comments on how to implement an example reader plugin. When we eventually have other hook specifications, we can revisit the "example" we set in
napari_{{cookiecutter.module_name}}.py