Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent being able to install plugins that are only available via PyPI on a bundle installation #112

Closed
wants to merge 1 commit into from

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Nov 5, 2024

Part of #110

Explores the option to prevent installing plugins that are only available through PyPI on bundle installations. This particular implementation uses some previously implemented logic to tag plugins as unavailable (disabling the install/action button, changing the plugin item style and showing a warning icon + tooltip). A preview:

imagen

Note: To check locally the items being disabled and the dialog layout as seen from a bundle installation, you need to replace/change

ON_BUNDLE = running_as_constructor_app()
IS_NAPARI_CONDA_INSTALLED = is_conda_package('napari')

for something like:

ON_BUNDLE = True
IS_NAPARI_CONDA_INSTALLED = True

Also, if this option gets favored over PR #111 probably some further styling needs to be done to the 'disabled' plugin items (to properly aling the warning icon, disable the installation info widget, etc)

@psobolewskiPhD
Copy link
Member

If this goes in, could the text-entry box at the bottom still be used to force a pip install?
I think I lean to the other option of letting a user force pip if they want....

@jaimergp
Copy link
Contributor

Closing this in favor of #111. We can still revisit in the future if we need something stricter. Thanks @dalthviz.

@jaimergp jaimergp closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants