Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bundled Python to v3.11 #189

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Bump bundled Python to v3.11 #189

merged 3 commits into from
Oct 17, 2024

Conversation

jaimergp
Copy link
Collaborator

@jaimergp jaimergp commented Oct 1, 2024

Comes from napari/napari-plugin-manager#108 (comment)

While we are at this, I'd like to formalize our policy for the bundled Python version, because we keep discussing this and the outcome is slightly different every time. I thought we wanted to use the oldest supported Python version for each release. As of today, 3.8 is still supported for one more month, 3.9 for one more year (more details). If that's "too old", what's the policy?

  • SPEC0: we would take 3.11, as 3.10 is now recommended to drop (as of today lol)
  • NEP29: that'd give us 3.10 now.
  • conda-forge pinnings, which don't follow a particular schedule, but consider it more conservative than NEP 29. At 3.9 now.
  • Python's EOL schedule: still at 3.8 for one more month, 3.9 for one more year.

This PR implements NEP29, but happy to adjust.

@jni
Copy link
Member

jni commented Oct 1, 2024

@jaimergp if we were going with "oldest", at any rate it would be "oldest according to SPEC-0", which just became 3.11.

@jni
Copy link
Member

jni commented Oct 1, 2024

(As far as I'm concerned SPEC-0 supersedes NEP-29 for packages other than NumPy.)

@jaimergp
Copy link
Collaborator Author

jaimergp commented Oct 1, 2024

Got it, will update. I'm curious, though, why is napari@main still on 3.9?

@jaimergp jaimergp changed the title Bump bundled Python to v3.10 Bump bundled Python to v3.11 Oct 1, 2024
@jni
Copy link
Member

jni commented Oct 1, 2024

why is napari@main still on 3.9?

Inertia, and also this old thread from Talley has made me at least slightly less gung-ho to rip stuff out until I see a need to do so. (e.g. 3.9 failing for some annoying reason would make me pull off the bandaid.)

But anyway I think we were meant to remove 3.9 after 0.5.0 was released, maybe even 0.4.19, it just hasn't been a priority.

@jaimergp jaimergp marked this pull request as ready for review October 1, 2024 17:58
@jaimergp
Copy link
Collaborator Author

So, are we ok with following SPEC-0 and bumping to 3.11 for the installer?

@jni
Copy link
Member

jni commented Oct 15, 2024

Yes please!

@jni
Copy link
Member

jni commented Oct 15, 2024

Well, if you want more opinions feel free to ping the relevant channels in Zulip 😅 (I'd say, plugins and bundle wg...)

@jni
Copy link
Member

jni commented Oct 15, 2024

But imho it is safe to bump to use SPEC0

@jaimergp
Copy link
Collaborator Author

I'll bring it up in Zulip and wait for comments for a couple days.

@jaimergp
Copy link
Collaborator Author

Let's merge this. Docs at napari/docs#501.

@jaimergp jaimergp merged commit 58bbe3f into main Oct 17, 2024
9 checks passed
@jaimergp jaimergp deleted the bump-python branch October 17, 2024 18:36
jni pushed a commit to napari/docs that referenced this pull request Oct 18, 2024
# Description

Document the decision of using SPEC-0 to dictate which Python version
should be bundled in each installer release. See
napari/packaging#189 and
https://napari.zulipchat.com/#narrow/channel/309872-plugins/topic/Bundled.20Python.20will.20be.20bumped.20to.203.2E11/near/476977691.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants