Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github CI #26

Merged
merged 6 commits into from
Apr 23, 2023
Merged

Add Github CI #26

merged 6 commits into from
Apr 23, 2023

Conversation

konovod
Copy link
Contributor

@konovod konovod commented Apr 23, 2023

Related to #15
This PR just adds workflow, building examples is separate problem (we should add them to examples folder and decide whether to just build or to run them. And how to stop them in latter case).

@naqvis naqvis merged commit f9364b1 into naqvis:master Apr 23, 2023
@naqvis
Copy link
Owner

naqvis commented Apr 23, 2023

@konovod CI build failing on Windows. Do we need to update std flag to -std=c++14?

https://github.com/naqvis/webview/actions/runs/4777495206/jobs/8493266000

@konovod
Copy link
Contributor Author

konovod commented Apr 24, 2023

Yes, i'm not even sure what is g++ in windows CI (mingw64 perhaps?) and would it successfully link with crystal program (crystal uses msvc on Windows, not mingw).
So i made a PR #28 with a compilation process suggested in README: it compiles webview to dll and copy lib file to crystal location.

@naqvis
Copy link
Owner

naqvis commented Apr 24, 2023

Thanks @konovod and yeah its good to use msvc for compilation on windows to avoid other mingw related issues. Thanks for the contributions and fixes 👍 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants