Factor common code into CalculateAverageTemperature

narugit · Aug 28, 2023 · c716e10 · c716e10
1 parent 0fdbdc4
commit c716e10
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 22 deletions.
diff --git a/smctemp.cc b/smctemp.cc
@@ -29,15 +29,13 @@
 #include <iostream>
 #include <limits>
 #include <string>
-#include <vector>
 
 #include "smctemp_string.h"
 
 #if defined(ARCH_TYPE_ARM64)
 #include <sys/sysctl.h>
 #include <algorithm>
 #include <array>
-#include <utility>
 
 namespace {
 std::string getCPUModel() {
@@ -384,6 +382,21 @@ kern_return_t SmcAccessor::PrintAll() {
   return kIOReturnSuccess;
 }
 
+double SmcTemp::CalculateAverageTemperature(const std::vector<std::string>& sensors,
+                                     const std::pair<unsigned int, unsigned int> limits) {
+  double temp = 0.0;
+  size_t valid_sensor_count = 0;
+  for (auto sensor : sensors) {
+    auto sensor_value = smc_accessor_.ReadValue(sensor.c_str());
+    if (sensor_value > 0.0) {
+      temp += sensor_value;
+      valid_sensor_count++;
+    }
+  }
+  temp /= valid_sensor_count;
+  return temp;
+}
+
 double SmcTemp::GetCpuTemp() {
   double temp = 0.0;
 #if defined(ARCH_TYPE_X86_64)
@@ -459,30 +472,12 @@ double SmcTemp::GetCpuTemp() {
     return temp;
   }
 
-  size_t valid_sensor_count = 0;
-  for (auto sensor : sensors) {
-    auto sensor_value = smc_accessor_.ReadValue(sensor.c_str());
-    if (sensor_value > valid_temperature_limits.first && sensor_value < valid_temperature_limits.second) {
-      temp += sensor_value;
-      valid_sensor_count++;
-    }
-  }
-  temp /= valid_sensor_count;
+  temp = CalculateAverageTemperature(sensors, valid_temperature_limits);
   if (temp > std::numeric_limits<double>::epsilon()) {
     return temp;
   }
 
-  size_t valid_aux_sensor_count = 0;
-  for (auto sensor : aux_sensors) {
-    auto sensor_value = smc_accessor_.ReadValue(sensor.c_str());
-    if (sensor_value > valid_temperature_limits.first && sensor_value < valid_temperature_limits.second) {
-      temp += sensor_value;
-      valid_aux_sensor_count++;
-    }
-  }
-  if (valid_aux_sensor_count > 0) {
-    temp /= valid_aux_sensor_count;
-  }
+  temp += CalculateAverageTemperature(aux_sensors, valid_temperature_limits);
 #endif
   return temp;
 }

diff --git a/smctemp.h b/smctemp.h
@@ -25,6 +25,8 @@
 
 #include <IOKit/IOKitLib.h>
 #include <string>
+#include <utility>
+#include <vector>
 
 #include "smctemp_types.h"
 
@@ -92,6 +94,8 @@ class SmcAccessor {
 
 class SmcTemp {
  private:
+  double CalculateAverageTemperature(const std::vector<std::string>& sensors,
+                                     const std::pair<unsigned int, unsigned int> limits);
   SmcAccessor smc_accessor_;
 
  public: