-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU temperature sensors #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enen92
force-pushed
the
gpu
branch
2 times, most recently
from
September 5, 2023 14:56
7df8770
to
3c948c0
Compare
@narugit any strong objections against this? |
narugit
reviewed
Sep 9, 2023
Just tested on my old x86 mac:
|
Here is my mac information. In my mac, there is no information about $ system_profiler SPSoftwareDataType SPHardwareDataType
Software:
System Software Overview:
System Version: macOS 12.6.3 (21G419)
Kernel Version: Darwin 21.6.0
Boot Volume: Macintosh HD
Boot Mode: Normal
Computer Name: Nac Rook Pro
User Name: naru (naru)
Secure Virtual Memory: Enabled
System Integrity Protection: Enabled
Time since boot: 10:38
Hardware:
Hardware Overview:
Model Name: MacBook Pro
Model Identifier: MacBookPro15,4
Processor Name: Quad-Core Intel Core i7
Processor Speed: 1.7 GHz
Number of Processors: 1
Total Number of Cores: 4
L2 Cache (per Core): 256 KB
L3 Cache: 8 MB
Hyper-Threading Technology: Enabled
Memory: 16 GB
System Firmware Version: 1916.80.2.0.0 (iBridge: 20.16.3045.0.0,0)
OS Loader Version: 540.120.3~22
Serial Number (system): ...
Hardware UUID: ...
Provisioning UDID: ...
Activation Lock Status: Disabled |
narugit
reviewed
Sep 9, 2023
narugit
reviewed
Sep 9, 2023
narugit
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@enen92 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for GPU sensors (Kodi uses the old smctemp project to obtain either the CPU or the GPU average temperature - ref: https://github.com/xbmc/xbmc/blob/master/xbmc/platform/darwin/osx/smc.h#L36-L42 and https://github.com/xbmc/xbmc/blob/d025684d226cb88f1169bf6dfcc60d5fe4312b67/xbmc/guilib/guiinfo/SystemGUIInfo.cpp#L97C1-L104).
Implementation is pretty similar to #14 - includes both x86 and M1/M2. SMC registers where obtained from the sensors project as well.
Verified this against the values provided by TGPro:
@joshuataylor your feedback is also appreciated here
Hopefully this one can be considered as well :)