-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename and sort sensor variable #28
Conversation
smctemp.h
Outdated
constexpr UInt32Char_t kSensorTc0e = "TC0E"; // CPU PECI die filtered temperature | ||
constexpr UInt32Char_t kSensorTc0f = "TC0F"; // CPU PECI die temperature filtered then adjusted | ||
constexpr UInt32Char_t kSensorTc0p = "TC0P"; // CPU proximity temperature | ||
constexpr UInt32Char_t kSensorTC0D = "TC0D"; // CPU die temperature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
smctemp.h
Outdated
constexpr UInt32Char_t kSensorTc0f = "TC0F"; // CPU PECI die temperature filtered then adjusted | ||
constexpr UInt32Char_t kSensorTc0p = "TC0P"; // CPU proximity temperature | ||
constexpr UInt32Char_t kSensorTC0D = "TC0D"; // CPU die temperature | ||
constexpr UInt32Char_t kSensorTC0E = "TC0E"; // CPU PECI die filtered temperature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
smctemp.h
Outdated
constexpr UInt32Char_t kSensorTc0p = "TC0P"; // CPU proximity temperature | ||
constexpr UInt32Char_t kSensorTC0D = "TC0D"; // CPU die temperature | ||
constexpr UInt32Char_t kSensorTC0E = "TC0E"; // CPU PECI die filtered temperature | ||
constexpr UInt32Char_t kSensorTC0F = "TC0F"; // CPU PECI die temperature filtered then adjusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
smctemp.h
Outdated
constexpr UInt32Char_t kSensorTC0D = "TC0D"; // CPU die temperature | ||
constexpr UInt32Char_t kSensorTC0E = "TC0E"; // CPU PECI die filtered temperature | ||
constexpr UInt32Char_t kSensorTC0F = "TC0F"; // CPU PECI die temperature filtered then adjusted | ||
constexpr UInt32Char_t kSensorTC0P = "TC0P"; // CPU proximity temperature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
About