Fix compile-time warnings and other nits #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jrabinow |
Before$ sudo make clean
$ sudo make 2>&1 | grep "warning"
clang: warning: -framework IOKit: 'linker' input unused [-Wunused-command-line-argument]
smctemp.cc:61:1: warning: 'OSSpinLock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock() from <os/lock.h> instead [-Wdeprecated-declarations]
smctemp.cc:153:3: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
smctemp.cc:214:3: warning: 'OSSpinLockLock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock_lock() from <os/lock.h> instead [-Wdeprecated-declarations]
smctemp.cc:242:3: warning: 'OSSpinLockUnlock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock_unlock() from <os/lock.h> instead [-Wdeprecated-declarations]
smctemp.cc:326:3: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
smctemp.cc:326:20: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
6 warnings generated.
clang: warning: -framework IOKit: 'linker' input unused [-Wunused-command-line-argument]
smctemp_string.cc:20:3: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
1 warning generated.
main.cc:26:26: warning: unused variable 'key' [-Wunused-variable]
main.cc:27:26: warning: unused variable 'val' [-Wunused-variable]
2 warnings generated.After$ sudo make clean
$ sudo make 2>&1 | grep "warning"
clang: warning: -framework IOKit: 'linker' input unused [-Wunused-command-line-argument]
smctemp.cc:61:1: warning: 'OSSpinLock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock() from <os/lock.h> instead [-Wdeprecated-declarations]
smctemp.cc:153:3: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
smctemp.cc:214:3: warning: 'OSSpinLockLock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock_lock() from <os/lock.h> instead [-Wdeprecated-declarations]
smctemp.cc:242:3: warning: 'OSSpinLockUnlock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock_unlock() from <os/lock.h> instead [-Wdeprecated-declarations]
smctemp.cc:326:24: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
5 warnings generated.
clang: warning: -framework IOKit: 'linker' input unused [-Wunused-command-line-argument] |
narugit
approved these changes
Jun 6, 2024
Comment on lines
-26
to
-27
| smctemp::UInt32Char_t key = { 0 }; | ||
| smctemp::SmcVal_t val; |
There was a problem hiding this comment.
note:
main.cc:26:26: warning: unused variable 'key' [-Wunused-variable]
main.cc:27:26: warning: unused variable 'val' [-Wunused-variable]| memset(&inputStructure, 0, sizeof(SmcKeyData_t)); | ||
| memset(&outputStructure, 0, sizeof(SmcKeyData_t)); | ||
| memset(&val, 0, sizeof(SmcVal_t)); | ||
|
|
||
| inputStructure.key = string_util::strtoul(key, 4, 16); | ||
| sprintf(val.key, key); |
There was a problem hiding this comment.
note:
smctemp.cc:326:3: warning: 'sprintf' is deprecated:
This function is provided for compatibility reasons only.
Due to security concerns inherent in the design of sprintf(3),
it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
narugit
requested changes
Jun 6, 2024
smctemp.cc
Outdated
| memset(&inputStructure, 0, sizeof(SmcKeyData_t)); | ||
| memset(&outputStructure, 0, sizeof(SmcKeyData_t)); | ||
| memset(&val, 0, sizeof(SmcVal_t)); | ||
|
|
||
| inputStructure.key = string_util::strtoul(key, 4, 16); | ||
| sprintf(val.key, key); | ||
|
|
||
| snprintf(val.key, 5, key); |
There was a problem hiding this comment.
Suggested change
| snprintf(val.key, 5, key); | |
| snprintf(val.key, sizeof(val.key), key); |
Could you use sizeof in second argument?
- prevent incorrect typecasting (comparison between signed and unsigned) - prevent buffer overflows by replacing sprintf with snprintf - remove unused variables - newline added in final output - add *.swp to gitignore - whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compile-time warnings and other nits