Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Evaluate unit test items marked "TODO" #108

Closed
jphickey opened this issue Dec 8, 2021 · 1 comment · Fixed by #267
Closed

Task: Evaluate unit test items marked "TODO" #108

jphickey opened this issue Dec 8, 2021 · 1 comment · Fixed by #267
Assignees
Labels
draco-rc2 unit-test Related to coverage or functional tests
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Dec 8, 2021

A simple search shows the text "TODO" currently appears 162 times in the CF source code, almost all of which are in unit test. Future work items should be tracked in the issue list, not in the source code.

  • If the intent is to actually do the work item, then there should be a github issue submitted to implement
  • If it is determined that the work item is not necessary after all, then remove the TODO comment.
@jphickey
Copy link
Contributor Author

Update - as of the current baseline, there are only 36 instances of "TODO" remaining and they are all in unit test code.

@skliper skliper added the unit-test Related to coverage or functional tests label Mar 24, 2022
@skliper skliper added this to the Draco milestone Jun 16, 2022
@skliper skliper self-assigned this Jun 16, 2022
skliper added a commit to skliper/CF that referenced this issue Jun 17, 2022
astrogeco added a commit that referenced this issue Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draco-rc2 unit-test Related to coverage or functional tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants