Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT fails to build if C library does not provide INTMAX_MAX #403

Closed
2 tasks done
jphickey opened this issue Aug 16, 2023 · 0 comments · Fixed by #404
Closed
2 tasks done

UT fails to build if C library does not provide INTMAX_MAX #403

jphickey opened this issue Aug 16, 2023 · 0 comments · Fixed by #404
Assignees
Labels
Milestone

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Non-compliant C libraries might not provide the INTMAX_MAX value. This is the case on VxWorks 6.9 and therefore the Any_int_GreaterThan() function fails to compile.

To Reproduce
Cross compile, with coverage tests, on VxWorks 6.9. Error is reported:

apps/cf/unit-test/utilities/cf_test_utils.c: In function 'Any_int_GreaterThan':
apps/cf/unit-test/utilities/cf_test_utils.c:458: error: 'INTMAX_MAX' undeclared (first use in this function)

Expected behavior
Build should succeed

System observed on:
VxWorks 6.9

Additional context
This function appears to not actually be used, so may be able to just remove it.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the bug label Aug 16, 2023
@jphickey jphickey self-assigned this Aug 16, 2023
jphickey added a commit to jphickey/CF that referenced this issue Aug 16, 2023
Do not assume INTMAX_MAX or UINT64_C macros are available.
Notably, these are absent on VxWorks 6.9,
dzbaker added a commit that referenced this issue Aug 17, 2023
Fix #403, patches for older system compatibility
@chillfig chillfig added this to the Equuleus milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants