Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dispatch pattern for CF #422

Closed
3 tasks done
jphickey opened this issue Dec 13, 2023 · 0 comments · Fixed by #426
Closed
3 tasks done

Implement dispatch pattern for CF #422

jphickey opened this issue Dec 13, 2023 · 0 comments · Fixed by #426
Assignees
@jphickey
Labels
enhancement

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the CF README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
The action of identifying the app pipe message and calling the proper handler should be in a separate source file.

Describe the solution you'd like
Move the code associated with identification and routing of messages to a separate source file called cf_dispatch.c

Describe alternatives you've considered
N/A

Additional context
This is the recommended pattern for all CFS apps, and CF doesn't yet follow it.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Dec 13, 2023
jphickey added a commit to jphickey/CF that referenced this issue Dec 13, 2023
@jphickey
Fix nasa#422, implement dispatcher pattern for CF
a844bf3 
Move message identification, validation, and routing to a separate
source file per the recommended CFS app patterns.
jphickey added a commit to jphickey/CF that referenced this issue Dec 13, 2023
@jphickey
Fix nasa#422, initial add of EDS
ba356b3 
Add an EDS XML file for CF, along with alternate dispatcher
to route messages based on EDS.
jphickey added a commit to jphickey/CF that referenced this issue Dec 13, 2023
@jphickey
Fix nasa#422, implement dispatcher pattern for CF
607bc17 
Move message identification, validation, and routing to a separate
source file per the recommended CFS app patterns.
jphickey added a commit to jphickey/CF that referenced this issue Dec 13, 2023
@jphickey
Fix nasa#422, initial add of EDS
ae0b011 
Add an EDS XML file for CF, along with alternate dispatcher
to route messages based on EDS.
jphickey added a commit to jphickey/CF that referenced this issue Dec 15, 2023
@jphickey
Fix nasa#422, implement dispatcher pattern for CF
0733ffd 
Move message identification, validation, and routing to a separate
source file per the recommended CFS app patterns.
@jphickey jphickey mentioned this issue Dec 15, 2023
Merged
2 tasks
jphickey added a commit to jphickey/CF that referenced this issue Dec 15, 2023
@jphickey
Fix nasa#422, initial add of EDS
3e425da 
Add an EDS XML file for CF, along with alternate dispatcher
to route messages based on EDS.
jphickey added a commit to jphickey/CF that referenced this issue Dec 15, 2023
@jphickey
Fix nasa#422, initial add of EDS
209dcfc 
Add an EDS XML file for CF, along with alternate dispatcher
to route messages based on EDS.
jphickey added a commit that referenced this issue Jan 11, 2024
@jphickey
Merge pull request #426 from jphickey/fix-422-dispatcher
ab17422 
Fix #422, implement dispatcher pattern for CF
jphickey added a commit to jphickey/CF that referenced this issue Jan 11, 2024
@jphickey
Fix nasa#422, initial add of EDS
a18ec4d 
Add an EDS XML file for CF, along with alternate dispatcher
to route messages based on EDS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #422, implement dispatcher pattern for CF jphickey/CF
1 participant
@jphickey