Fix #361, add option for trailer bytes in CFDP PDUs #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Adds an option to insert platform-specific padding at the end of CFDP PDU encapsulation. The padding area may be utilized by the deployment to add arbitrary verification information to the PDU.
Fixes #361
Testing performed
Build and run all tests
Run a CFDP file transfer
Expected behavior changes
None with default config. New config option allows user to add padding to the end of CFDP PDUs for trailer bytes.
System(s) tested on
Debian
Additional context
The extra space is added only to the SB encapsulation of CFDP PDUs, this is not within the CFDP PDU itself (that is, the size inside the CFDP PDU does not include these extra bytes, but the size in the CFE SB message that holds the PDU does include it).
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.