Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #361, add option for trailer bytes in CFDP PDUs #362

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Adds an option to insert platform-specific padding at the end of CFDP PDU encapsulation. The padding area may be utilized by the deployment to add arbitrary verification information to the PDU.

Fixes #361

Testing performed
Build and run all tests
Run a CFDP file transfer

Expected behavior changes
None with default config. New config option allows user to add padding to the end of CFDP PDUs for trailer bytes.

System(s) tested on
Debian

Additional context
The extra space is added only to the SB encapsulation of CFDP PDUs, this is not within the CFDP PDU itself (that is, the size inside the CFDP PDU does not include these extra bytes, but the size in the CFE SB message that holds the PDU does include it).

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Adds an option to insert platform-specific padding at the end of CFDP
PDU encapsulation.  The padding area may be utilized by the deployment
to add arbitrary verification information to the PDU.
@jphickey jphickey added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:FastTrack labels Jan 31, 2023
Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dzbaker dzbaker merged commit 19c18b9 into nasa:main Feb 1, 2023
@dzbaker dzbaker added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:FastTrack labels Feb 2, 2023
@dmknutsen dmknutsen added this to the Draco milestone Feb 6, 2023
@jphickey jphickey deleted the fix-361-trailer-padding branch April 17, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for padding bytes / trailer at end of CF PDU
4 participants