Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #82, Convert integers holding boolean truth values to bool #83

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented May 2, 2023

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully.

Expected behavior changes
No change to behavior.

  • intent of these variables is more clear
  • improved type-safety
  • eases future maintainability

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-82-convert-boolean-integers-to-bool branch from 3d8269d to f28181d Compare May 4, 2023 11:51
@dzbaker dzbaker requested a review from jphickey May 4, 2023 18:38
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be sure that we don't change the tables or command message formats with this

fsw/inc/cs_msg.h Outdated Show resolved Hide resolved
fsw/inc/cs_tbldefs.h Outdated Show resolved Hide resolved
@thnkslprpt thnkslprpt force-pushed the fix-82-convert-boolean-integers-to-bool branch from f28181d to aa585b7 Compare May 4, 2023 20:44
@thnkslprpt thnkslprpt requested a review from jphickey May 4, 2023 20:45
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to revert the changes to "cs_tbldefs.h" .... Everything in this struct should be based on known-width types only - no "bool" or "cpuaddr". So there were prexisting problems there. But the proposed change will alter alignment and still uses bool and cpuaddr.

The change to "cs_compute.c" is good though.

@thnkslprpt thnkslprpt force-pushed the fix-82-convert-boolean-integers-to-bool branch from aa585b7 to cabac30 Compare September 30, 2023 04:37
@thnkslprpt
Copy link
Contributor Author

I think we still need to revert the changes to "cs_tbldefs.h" .... Everything in this struct should be based on known-width types only - no "bool" or "cpuaddr". So there were prexisting problems there. But the proposed change will alter alignment and still uses bool and cpuaddr.

The change to "cs_compute.c" is good though.

@jphickey No worries - I removed the changes to cs_tbldefs.h - unless you want me to remove the bool's that are already in there?

@dzbaker dzbaker merged commit f29e12d into nasa:main Feb 8, 2024
17 checks passed
@thnkslprpt thnkslprpt deleted the fix-82-convert-boolean-integers-to-bool branch February 8, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integers representing boolean truth values should be converted to bool
4 participants