Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-91-buffer-overflow-unit-test #92

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

avan989
Copy link

@avan989 avan989 commented Apr 1, 2024

Fix #91, Resolve buffer overflow in CS_RecomputeAppChildTask_Test_CouldNotGetAddress and CS_RecomputeTablesChildTask_Test_CouldNotGetAddress

Checklist (Please check before submitting)

Describe the contribution
A clear and concise description of what the contribution is.
Fix #91, update the unit test table array to be the same length as the actual.

Testing performed
Steps taken to test the contribution:

  1. Add add_compile_options(-fsanitize=address -g) and add_link_options(-fsanitize=address) to arch_build_custom.cmake file
  2. Make SIMULATION=native ENABLE_UNIT_TESTS=true SANTIZE=true prep
  3. make install
  4. make test

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
no impact to behavior. only unit test changed.

System(s) tested on
gcc (Ubuntu 10.5.0-1ubuntu1~20.04) 10.5.0

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLA's apply to software contributions.

Anh Van, GSFC

Fix nasa#91, Resolve buffer overflow in CS_RecomputeAppChildTask_Test_CouldNotGetAddress and
CS_RecomputeTablesChildTask_Test_CouldNotGetAddress
@dzbaker dzbaker merged commit 69fc1b9 into nasa:main Apr 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cs_compute_tests.c unit test causing an buffer overflow
2 participants