Fix #93, Replaces strncpy and strlen

[chillfig]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution

• Fixes Static analysis issues JSC 2.1 #93. Adds dispositions to line of code in question from static analysis stating why it's safe to keep as-is. Replacing strncpy with snprintf to enhance safety and compliance. Replaces strlen for purposes of verifying non-empty string with memchr.

Testing performed
build, lcov

Expected behavior changes
None

System(s) tested on

• OS: Ubuntu 22.04

Additional context
snprintf() guarentees null-termination at the line whereas strncpy() does not. This change helps comply with safety assurance.

Depends on nasa/osal#1465

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems

[chillfig]

CCB 06/13/2024: replace strncpy() with CFE_SB_MessageStringGet(). Snprintf() is slow and not preferable

Edit: Leaving snprintf()

[chillfig]

CCB 06/13/2024: replace strncpy() with CFE_SB_MessageStringGet(). Snprintf() is slow and not preferable

Edit: Leaving snprintf()

memchr has now been used to replace strlen

[dzbaker]

CCB 27 June 2024: Will re-run workflows once osal#1465 is merged in to verify they pass.