Fix #97, Remove dead code checks: NULL bufptr and RunStatus_SYS_EXCEPTION
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -59,10 +59,10 @@ | |||
| /* CS Reset Application counters command */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| void CS_ResetCmd(const CS_NoArgsCmd_t *CmdPtr) | |||
| void CS_ResetCountersCmd(const CS_NoArgsCmd_t *CmdPtr) | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_ES_RunStatus_SYS_EXCEPTIONandNULLbufptr#97Dead Code removed (along with their accompanying tests):
bufptrcannot beNULLafter a successful return fromCFE_SB_ReceiveBufferCFE_ES_RunStatus_SYS_EXCEPTIONnot necessary (and impossible to reach other than through forced test conditions) given that the code setting that status was removed at some point in the pastMinor changes to improve consistency and use the preferred symbol naming conventions:
CmdCountertoComandCounterCmdErrCountertoCommandErrorCounterCS_ResetCmdtoCS_ResetCountersCmdTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
Remove dead code to reduce unnecessary clutter.
System(s) tested on
Debian 12 using the current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt