Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apps should use CFE_MSG_PTR macro instead of cast or local unwrapping #15

Closed
skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #91
Closed

Apps should use CFE_MSG_PTR macro instead of cast or local unwrapping #15

skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #91
Assignees
@jphickey
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

Apps typically cast to a CFE_MSG_Message_t or use *.Msg. Better to use abstracted CFE_MSG_PTR. NOTE - Not backwards compatible with Caelum so recommend not addressing in Draco.

Imported from GSFCCFS-1900
@jphickey jphickey self-assigned this Jan 24, 2023
jphickey added a commit to jphickey/FM that referenced this issue Mar 7, 2023
@jphickey
Fix nasa#15, use CFE_MSG_PTR macro
ca2c4fc 
This requires headers to be named correctly per CFE_MSG definitions.
Includes other remaining cleanup items
jphickey added a commit to jphickey/FM that referenced this issue Mar 9, 2023
@jphickey
Fix nasa#15, use CFE_MSG_PTR macro
5039f7c 
This requires headers to be named correctly per CFE_MSG definitions.
Includes other remaining cleanup items
@jphickey jphickey mentioned this issue Mar 9, 2023
Merged
2 tasks
jphickey added a commit to jphickey/FM that referenced this issue Mar 9, 2023
@jphickey
Fix nasa#15, use CFE_MSG_PTR macro
268140a 
This requires headers to be named correctly per CFE_MSG definitions.
Includes other remaining cleanup items.  This renames command code
macro names and command structure names so that they all match.
dzbaker added a commit that referenced this issue Mar 10, 2023
@dzbaker
Merge pull request #91 from jphickey/fix-15-use-msgptr
9d3daa7 
Fix #15, use CFE_MSG_PTR macro
@chillfig chillfig added this to the Equuleus milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #15, use CFE_MSG_PTR macro jphickey/FM
3 participants
@jphickey @skliper @chillfig