Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit coverage, update to 100% code/branch or write issues where unreachable #17

Closed
skliper opened this issue Apr 22, 2022 · 0 comments
Closed

Revisit coverage, update to 100% code/branch or write issues where unreachable #17

skliper opened this issue Apr 22, 2022 · 0 comments
Assignees
@chillfig @havencarlson
Labels
coverage draco-rc2
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

Failure: Coverage cs lines 99.9% functions 100.0% branches 99.1%
Failure: Coverage ds lines 99.6% functions 100.0% branches 97.7%
Failure: Coverage fm lines 93.8% functions 94.0% branches 89.1%
Failure: Coverage hs lines 100.0% functions 100.0% branches 98.1%
Failure: Coverage lc lines 99.6% functions 100.0% branches 94.3%
Failure: Coverage md lines 98.4% functions 100.0% branches 96.7%
Failure: Coverage sc lines 99.9% functions 100.0% branches 99.0%

Fix where possible, elsewise Issues should document all uncovered lines/branches and disposition (why it's ok as-is)

Imported from GSFCCFS-1935
@skliper skliper added this to the Draco milestone Apr 22, 2022
chillfig added a commit to chillfig/FM that referenced this issue Jun 3, 2022
@chillfig
Fix nasa#17, Adds unit test fixes for increased coverage
4ed10d1
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 8, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
85f4f51
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 8, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
037250e
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 8, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
cd63bf3
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 8, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
e924f99
This was referenced Jun 8, 2022
Merged
Closed
chillfig added a commit to chillfig/FM that referenced this issue Jun 9, 2022
@chillfig
Fix nasa#17, update code coverage
892c144 
Increases code coverage for fm_child_tests.c and fm_cmds_tests.c
chillfig added a commit to chillfig/FM that referenced this issue Jun 9, 2022
@chillfig
Fix nasa#17, update code coverage
1c5c1d2 
Increases code coverage for fm_child_tests.c and fm_cmds_tests.c
@chillfig chillfig mentioned this issue Jun 9, 2022
Merged
2 tasks
chillfig added a commit to chillfig/FM that referenced this issue Jun 9, 2022
@chillfig
Fix nasa#17, update code coverage
f6a22dd 
Increases code coverage for fm_child_tests.c and fm_cmds_tests.c
chillfig added a commit to chillfig/FM that referenced this issue Jun 9, 2022
@chillfig
Fix nasa#17, update code coverage
2f780e3 
Increases code coverage for fm_child_tests.c and fm_cmds_tests.c
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 13, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
adfc491
chillfig added a commit to chillfig/FM that referenced this issue Jun 13, 2022
@chillfig
Fix nasa#17, update code coverage
4d12579 
Increases code coverage for fm_child_tests.c and fm_cmds_tests.c
chillfig added a commit to chillfig/FM that referenced this issue Jun 13, 2022
@chillfig
Part nasa#17, update code coverage fm_child_tests.c and fm_cmds_tests.c
2d225fe
chillfig added a commit to chillfig/FM that referenced this issue Jun 13, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
2b30663 
…eteDirCmd, FM_Cmds
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 14, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
2af1bdf
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 14, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
7f52693
chillfig added a commit to chillfig/FM that referenced this issue Jun 14, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
efa4342 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
chillfig added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
6ebb81e 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
chillfig added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
1e0a126 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
chillfig added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
6b71fb5 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
chillfig added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
3590478 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
chillfig added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
a4d0da4 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
chillfig added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
dbc9359 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
chillfig added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
60dc202 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
chillfig added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
1f5dff9 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 15, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
13062f1
chillfig added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
c3dc61f 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
Added real numbers in place of "any" macros, Added UtAssert_STUB_Count()
skliper added a commit to chillfig/FM that referenced this issue Jun 15, 2022
@skliper
Part nasa#17, Clean up Test_FM_ChildDirListFileLoop coverage test
bb2ad6f
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 16, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
2273fa6
chillfig added a commit to chillfig/FM that referenced this issue Jun 16, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
ae12e0f 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
Added real numbers in place of "any" macros, Added UtAssert_STUB_Count()
Cleans up Test_FM_ChildDeleteDirCmd_StrCmpThisDirectoryZero
chillfig added a commit to chillfig/FM that referenced this issue Jun 16, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
6714f5f 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
Added real numbers in place of "any" macros, Added UtAssert_STUB_Count()
Cleans up Test_FM_ChildDeleteDirCmd_StrCmpThisDirectoryZero
chillfig added a commit to chillfig/FM that referenced this issue Jun 16, 2022
@chillfig
Part nasa#17, update code coverage for FM_ChildSleepStat, FM_ChildDel…
b3db530 
…eteDirCmd, FM_Cmds

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
Added real numbers in place of "any" macros, Added UtAssert_STUB_Count()
Cleans up Test_FM_ChildDeleteDirCmd_StrCmpThisDirectoryZero
skliper added a commit to chillfig/FM that referenced this issue Jun 16, 2022
@skliper
Part nasa#17, Clean up Test_FM_ChildDirListFileLoop coverage test
384315a
havencarlson added a commit to havencarlson/FM that referenced this issue Jun 16, 2022
@havencarlson
Fix nasa#17, update code coverage for fm_cmd_utils.c
909f6c8
chillfig added a commit to chillfig/FM that referenced this issue Jun 17, 2022
@chillfig
Part nasa#17, coverage for FM_ChildSleepStat, FM_ChildDeleteDirCmd, F…
d5a7173 
…M_Cmds, FM_ChildDirListFileLoop

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
Added real numbers in place of "any" macros, Added UtAssert_STUB_Count()
Cleans up Test_FM_ChildDeleteDirCmd_StrCmpThisDirectoryZero
Adds UtAssert_VOIDCALL for FM_ChildSleepStat
Clean up Test_FM_ChildDirListFileLoop coverage test
chillfig added a commit to chillfig/FM that referenced this issue Jun 17, 2022
@chillfig
Part nasa#17, coverage for FM_ChildSleepStat, FM_ChildDeleteDirCmd, F…
65c617b 
…M_Cmds, FM_ChildDirListFileLoop

Removed UtAsserts for FM_ChildSizeTimeMode
Removed UtAssert for CFE_ES_ExitChildTask
Updated whitespace to clang format
Added Test_FM_ChildDirListFileLoop_BytesWrittenNotEqualWriteLengthInLoop
Added real numbers in place of "any" macros, Added UtAssert_STUB_Count()
Cleans up Test_FM_ChildDeleteDirCmd_StrCmpThisDirectoryZero
Adds UtAssert_VOIDCALL for FM_ChildSleepStat
Clean up Test_FM_ChildDirListFileLoop coverage test
astrogeco added a commit that referenced this issue Jun 17, 2022
@astrogeco
Merge pull request #33 from havencarlson/lcov
c651341 
Fix #17, update code coverage for fm_cmd_utils.c
astrogeco added a commit that referenced this issue Jun 22, 2022
@astrogeco
Merge pull request #35 from chillfig/lcov
4336824 
Part #17, update code coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chillfig chillfig

@havencarlson havencarlson

Labels
coverage draco-rc2
Projects
None yet
Milestone
Draco
Development

No branches or pull requests
3 participants
@skliper @chillfig @havencarlson