Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generated stubs for all internal functions #79

Closed
3 tasks done
jphickey opened this issue Jan 30, 2023 · 0 comments · Fixed by #80
Closed
3 tasks done

Use generated stubs for all internal functions #79

jphickey opened this issue Jan 30, 2023 · 0 comments · Fixed by #80
Assignees
@jphickey
Labels
Equuleus-rc1 unit-test
Milestone
Equuleus

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
FM divides its coverage test into separate units and uses stubs for all units other than the unit under test. However, this appears to be a mixture of hand-written and some generated stubs, and the hand written stubs can diverge from the implementation.

Describe the solution you'd like
Re-run the UT assert generate stubs script and use the generated stubs only.

Additional context
This makes the UT stubs easier to maintain - any time a header file changes, just re-run the tool and re-commit the stubs. It is best not to modify the generated stub in any way, if it can be avoided.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jan 30, 2023
jphickey added a commit to jphickey/FM that referenced this issue Jan 30, 2023
@jphickey
Fix nasa#79, generate stubs for internal functions
e2e6d85 
Regenerate the stubs for fm_child, fm_cmds, and fm_tbl internal units
using the UT assert stub generator tool.
@jphickey jphickey mentioned this issue Jan 30, 2023
Merged
2 tasks
jphickey added a commit to jphickey/FM that referenced this issue Feb 9, 2023
@jphickey
Fix nasa#79, generate stubs for internal functions
bb27cff 
Regenerate the stubs for fm_child, fm_cmds, and fm_tbl internal units
using the UT assert stub generator tool.
jphickey added a commit to jphickey/FM that referenced this issue Feb 9, 2023
@jphickey
Fix nasa#79, generate stubs for internal functions
46e9ae5 
Regenerate the stubs for fm_child, fm_cmds, and fm_tbl internal units
using the UT assert stub generator tool.
dzbaker added a commit that referenced this issue Feb 9, 2023
@dzbaker
Merge pull request #80 from jphickey/fix-79-use-generated-stubs
5dc72f5 
Fix #79, generate stubs for internal functions
@dzbaker dzbaker added this to the Equuleus milestone Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
Equuleus-rc1 unit-test
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #79, generate stubs for internal functions jphickey/FM
4 participants
@dzbaker @jphickey @dmknutsen @chillfig