Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15, use CFE_MSG_PTR macro #91

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Fix #15, use CFE_MSG_PTR macro #91

merged 1 commit into from
Mar 10, 2023

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Mar 9, 2023

Checklist (Please check before submitting)

Describe the contribution
Use of CFE_MSG_PTR requires objects and members to be named correctly per CFE_MSG definitions. Includes other remaining cleanup items. Mainly:

  1. Consistency in naming of header objects
  2. Consistency in naming between command names and command handler functions (fix missing words, fix mismatch abbreviations, etc)

Fixes #15

Testing performed
Build and run all tests

Expected behavior changes
No impact to behavior. More future proof code.

System(s) tested on
Debian

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 9, 2023
View reviewed changes
fsw/src/fm_child.c
@@ -1000,7 +1000,7 @@
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

void FM_ChildDeleteDirCmd(const FM_ChildQueueEntry_t *CmdArgs)
void FM_ChildDeleteDirectoryCmd(const FM_ChildQueueEntry_t *CmdArgs)

Check notice

Code scanning / CodeQL-coding-standard

Function too long

FM_ChildDeleteDirectoryCmd has too many lines (71, while 60 are allowed).
fsw/src/fm_child.c
@@ -625,7 +625,7 @@
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

void FM_ChildConcatCmd(const FM_ChildQueueEntry_t *CmdArgs)
void FM_ChildConcatFilesCmd(const FM_ChildQueueEntry_t *CmdArgs)

Check notice

Code scanning / CodeQL-coding-standard

Function too long

FM_ChildConcatFilesCmd has too many lines (167, while 60 are allowed).
fsw/src/fm_child.c
@@ -434,7 +434,7 @@
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

void FM_ChildDeleteAllCmd(FM_ChildQueueEntry_t *CmdArgs)
void FM_ChildDeleteAllFilesCmd(FM_ChildQueueEntry_t *CmdArgs)

Check notice

Code scanning / CodeQL-coding-standard

Function too long

FM_ChildDeleteAllFilesCmd has too many lines (144, while 60 are allowed).
fsw/src/fm_app.c
@@ -387,14 +387,14 @@
/* FM application -- housekeeping request packet processor */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void FM_ReportHK(const CFE_MSG_CommandHeader_t *Msg)
void FM_SendHkCmd(const CFE_SB_Buffer_t *BufPtr)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/fm_child.c
@@ -1000,7 +1000,7 @@
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

void FM_ChildDeleteDirCmd(const FM_ChildQueueEntry_t *CmdArgs)
void FM_ChildDeleteDirectoryCmd(const FM_ChildQueueEntry_t *CmdArgs)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/fm_child.c
@@ -961,7 +961,7 @@
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

void FM_ChildCreateDirCmd(const FM_ChildQueueEntry_t *CmdArgs)
void FM_ChildCreateDirectoryCmd(const FM_ChildQueueEntry_t *CmdArgs)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/fm_child.c
@@ -625,7 +625,7 @@
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

void FM_ChildConcatCmd(const FM_ChildQueueEntry_t *CmdArgs)
void FM_ChildConcatFilesCmd(const FM_ChildQueueEntry_t *CmdArgs)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/fm_child.c
@@ -585,7 +585,7 @@
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

void FM_ChildDecompressCmd(const FM_ChildQueueEntry_t *CmdArgs)
void FM_ChildDecompressFileCmd(const FM_ChildQueueEntry_t *CmdArgs)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/fm_child.c
@@ -434,7 +434,7 @@
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */

void FM_ChildDeleteAllCmd(FM_ChildQueueEntry_t *CmdArgs)
void FM_ChildDeleteAllFilesCmd(FM_ChildQueueEntry_t *CmdArgs)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
@jphickey
Fix nasa#15, use CFE_MSG_PTR macro
268140a 
This requires headers to be named correctly per CFE_MSG definitions.
Includes other remaining cleanup items.  This renames command code
macro names and command structure names so that they all match.
@dzbaker dzbaker merged commit 9d3daa7 into nasa:main Mar 10, 2023
@jphickey jphickey deleted the fix-15-use-msgptr branch March 17, 2023 16:26
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging this pull request may close these issues.

Apps should use CFE_MSG_PTR macro instead of cast or local unwrapping
4 participants
@jphickey @dzbaker @dmknutsen @chillfig