Fix #73, compression selectable at source file level #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -236,6 +236,8 @@ | |||
| } | |||
| } | |||
|
|
|||
| FM_CompressionService_Init(); | |||
Check warning
Code scanning / CodeQL-security
Expression has no effect
Adds a cmake option for compression sub-component implementation. This replaces the FM_INCLUDE_DECOMPRESS option in fm_platform_cfg.h. Currently available options are: - fslib (should be equivalent to FM_INCLUDE_DECOMPRESS set) - none (should be equivalent to FM_INCLUDE_DECOMPRESS unset) - zlib (stub for future work) This lays the groundwork to support compression in addition to decompression, using an external 3rd part library if desired.
jphickey
force-pushed
the
fix-73-decompress
branch
from
b8e2963
to
39d2651
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Adds a cmake option for compression sub-component implementation. This replaces the FM_INCLUDE_DECOMPRESS option in fm_platform_cfg.h.
Currently available options are:
This lays the groundwork to support compression in addition to decompression, using an external 3rd part library if desired.
Fixes #73
Testing performed
Build and run all tests
Expected behavior changes
Compression option no longer in header file - now in a CMake option with source selection. Basically equivalent though.
System(s) tested on
Debian
Additional context
All conditional compilation (
#ifdef) around compression has been removed. This comprised a fair bit of code in FM that was not being tested in any workflow because compression is usually disabled.Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.