Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split "platform_cfg" into external and internal components #50

Open
3 tasks done
jphickey opened this issue Mar 28, 2023 · 0 comments · May be fixed by #57
Open
3 tasks done

Split "platform_cfg" into external and internal components #50

jphickey opened this issue Mar 28, 2023 · 0 comments · May be fixed by #57
Labels
enhancement good first issue

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Currently, all configurable items for the app are contained in a single hk_platform_cfg.h header file. This contains macro definitions that affect both the internal operation of the application (such as operational limits) as well as the external interface in CMD/TLM and table files.

Describe the solution you'd like
Split this header into two components, one that contains only public items (i.e. those that affect CMD/TLM/Table definitions) and one that contains private/internal items that are only used within the local application code and do not affect the interface.

Additional context
Mainly a scoping concern, separate files for separate scopes. These files could also be generated in the future, but scope still needs to be consistent.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
thnkslprpt added a commit to thnkslprpt/HK that referenced this issue Sep 8, 2023
@thnkslprpt
Fix nasa#50, Separate config files
1930a6f
thnkslprpt added a commit to thnkslprpt/HK that referenced this issue Sep 8, 2023
@thnkslprpt
Fix nasa#50, Separate config files
5a6520f
@thnkslprpt thnkslprpt linked a pull request Sep 8, 2023 that will close this issue
Open
2 tasks
thnkslprpt added a commit to thnkslprpt/HK that referenced this issue Oct 26, 2023
@thnkslprpt
Fix nasa#50, Separate config files
cb7fdaa
jphickey added a commit to jphickey/HK that referenced this issue Sep 23, 2024
@jphickey
Fix nasa#50, split configuration files and allow overrides
21351f3 
Move most header files to a "config" directory and use the
"generate_config_includefile" function to create wrappers for app use.
This allows the configuration to be more easily modified by users - they
can simply provide a file in their own defs directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #50, Split up config files thnkslprpt/HK
2 participants
@jphickey @chillfig