Fix #45, Apply consistent Event ID names to common events #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
requested changes
Nov 1, 2022
fsw/src/lc_msgdefs.h
Outdated
| @@ -161,7 +161,7 @@ | |||
| * Successful execution of this command may be verified with | |||
| * the following telemetry: | |||
| * - #LC_HkPacket_t.CmdCount will be cleared | |||
| * - The #LC_RESET_DBG_EID debug event message will be | |||
| * - The #LC_RESET_INF_EID debug event message will be | |||
There was a problem hiding this comment.
if LC_RESET_INF_EID is to be changed to of an INFORMATION type, these comments may need updating
Suggested change
| * - The #LC_RESET_INF_EID debug event message will be | |
| * - The #LC_RESET_INF_EID informational event message will be |
fsw/src/lc_events.h
Outdated
| @@ -401,7 +401,7 @@ | |||
| * This event message is issued when a reset counters command has | |||
| * been received. | |||
| */ | |||
| #define LC_RESET_DBG_EID 27 | |||
| #define LC_RESET_INF_EID 27 | |||
There was a problem hiding this comment.
Line 397 may need updating to Type: INFORMATION.
There was a problem hiding this comment.
I think I've updated both those changes now with the force-push Justin.
Thanks
thnkslprpt
force-pushed
the
fix-45-apply-consistent-event-id-names
branch
from
a894892
to
d427f97
Compare
thnkslprpt
force-pushed
the
fix-45-apply-consistent-event-id-names
branch
from
d427f97
to
c78ec3a
Compare
thnkslprpt
force-pushed
the
fix-45-apply-consistent-event-id-names
branch
2 times, most recently
from
1c38e4f
to
8ef96e5
Compare
thnkslprpt
force-pushed
the
fix-45-apply-consistent-event-id-names
branch
from
8ef96e5
to
4521deb
Compare
thnkslprpt
force-pushed
the
fix-45-apply-consistent-event-id-names
branch
from
4521deb
to
e32aa19
Compare
thnkslprpt
force-pushed
the
fix-45-apply-consistent-event-id-names
branch
from
e32aa19
to
af3954b
Compare
dzbaker
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Testing performed
Only GitHub CI actions.
Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.
Contributor Info
Avi Weiss @thnkslprpt