Fix #9, move Memory Types to enums #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -302,7 +302,7 @@ | |||
| /* Verify load/dump memory parameters */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| bool MM_VerifyLoadDumpParams(cpuaddr Address, uint8 MemType, uint32 SizeInBytes, uint8 VerifyType) | |||
| bool MM_VerifyLoadDumpParams(cpuaddr Address, MM_MemType_t MemType, uint32 SizeInBytes, uint8 VerifyType) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| @@ -139,7 +139,7 @@ | |||
| /* Verify peek and poke command parameters */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| bool MM_VerifyPeekPokeParams(cpuaddr Address, uint8 MemType, uint8 SizeInBits) | |||
| bool MM_VerifyPeekPokeParams(cpuaddr Address, MM_MemType_t MemType, uint8 SizeInBits) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| @@ -302,7 +302,7 @@ | |||
| /* Verify load/dump memory parameters */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| bool MM_VerifyLoadDumpParams(cpuaddr Address, uint8 MemType, uint32 SizeInBytes, uint8 VerifyType) | |||
| bool MM_VerifyLoadDumpParams(cpuaddr Address, MM_MemType_t MemType, uint32 SizeInBytes, uint8 VerifyType) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long
| @@ -139,7 +139,7 @@ | |||
| /* Verify peek and poke command parameters */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| bool MM_VerifyPeekPokeParams(cpuaddr Address, uint8 MemType, uint8 SizeInBits) | |||
| bool MM_VerifyPeekPokeParams(cpuaddr Address, MM_MemType_t MemType, uint8 SizeInBits) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fix #9, created enum MM_MemType_t for memory types
Testing performed
Unit testing
Expected behavior changes
No impact to behavior
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA