Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate definition/use of OS_VolumeTable #161

Closed
jphickey opened this issue May 14, 2020 · 1 comment · Fixed by #163 or #166
Closed

Deprecate definition/use of OS_VolumeTable #161

jphickey opened this issue May 14, 2020 · 1 comment · Fixed by #163 or #166
Assignees
@jphickey
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
OSAL has an API where volume table mappings can be added during the startup code, rendering the static OS_VolumeTable object unnecessary.

Describe the solution you'd like
Use the OSAL API to register the FS_BASED file system mappings, and remove OS_VolumeTable.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this May 14, 2020
@jphickey
Copy link
Contributor Author

Related to nasa/osal#367, and nasa/osal#449.

Proposal is to deprecate everything related to backward compatibility with OS_VolumeTable, so references to this need to be removed for compatibility.

@jphickey jphickey added the enhancement New feature or request label May 14, 2020
@skliper skliper added this to the 1.5.0 milestone May 14, 2020
@jphickey jphickey mentioned this issue May 14, 2020
Merged
@jphickey jphickey mentioned this issue May 27, 2020
Merged
@jphickey jphickey linked a pull request May 27, 2020 that will close this issue
Fix #161, remove OS_VolumeTable #163
Merged
astrogeco pushed a commit that referenced this issue May 27, 2020
@jphickey
Fix #161, remove OS_VolumeTable
26f512d 
Replace with call to OS_FileSysAddFixedMap() for the FS_BASED
entries.  Other types are already handled at runtime anyway.
astrogeco added a commit that referenced this issue May 27, 2020
@astrogeco
Merge pull request #163 from jphickey/fix-161-remove-voltabs
bb9c39c 
Fix #161, remove OS_VolumeTable
@astrogeco astrogeco mentioned this issue May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #161, remove OS_VolumeTable jphickey/PSP
Integration candidate: 2020-05-20 nasa/PSP
2 participants
@jphickey @skliper