CFE_PSP_Module_FindByName does not find base modules

[jphickey]

Describe the bug
PSP modules can be enabled in two ways, either by adding to the ${cpuname}_PSP_MODULELIST in targets.cmake (for optional/platform-specific hardware access routines) or a set of "standard" modules listed in psp_module_list.cmake file under the PSP.

Problem is that CFE_PSP_Module_FindByName() only looks at the user-specified list (from targets.cmake) and not the list of standard modules.

This is needed for HS because the linux_sysmon monitor (for cpu utilization) is now listed as a standard module for pc-linux PSP, but this inadvertently made it un-findable.

To Reproduce
Run the current build of framework + HS app (which relies on being able to locate the linux_sysmon module). HS does not find a module and disables CPU usage reporting.

Expected behavior
HS should find the module and enable usage reporting

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

[avan989]

@jphickey @dmknutsen It looks like it was intentional from the comments that only the global_config. PspModuleList was supposed to use CFE_PSP_Module_FindByName() and not the base_module. Do we still want to change it so it can look up both lists?

Note:
CFE_PSP_Module_GetAPIEntry also needs to be updated to work.

PSP/fsw/shared/src/cfe_psp_module.c

Lines 45 to 52 in 47d2c1e

	* Internal/base modules typically should not be the subject
	* of a call to CFE_PSP_Module_FindByName or GetAPI,
	* so they are assigned IDs at the END of the space,
	* this makes them unique but they are otherwise not used
	*
	* Reserve the last 256 entries for base modules
	*/
	#define CFE_PSP_INTERNAL_MODULE_BASE ((CFE_PSP_MODULE_BASE | CFE_PSP_MODULE_INDEX_MASK) & ~0xFF)

PSP/fsw/shared/src/cfe_psp_module.c

Lines 98 to 103 in 47d2c1e

	/* First initialize the fixed set of modules for this PSP */
	CFE_PSP_ModuleInitList(CFE_PSP_INTERNAL_MODULE_BASE, CFE_PSP_BASE_MODULE_LIST);
	/* Then initialize any user-selected extension modules */
	/* Only these modules can be used with CFE_PSP_Module_GetAPIEntry or CFE_PSP_Module_FindByName */
	CFE_PSP_ConfigPspModuleListLength = CFE_PSP_ModuleInitList(CFE_PSP_MODULE_BASE, GLOBAL_CONFIGDATA.PspModuleList);