Fix #393, find psp standard module #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avan989
force-pushed
the
fix-393-psp-find-module-by-name
branch
from
3f82e7e
to
a98bf07
Compare
avan989
changed the title
avan989
force-pushed
the
fix-393-psp-find-module-by-name
branch
from
a98bf07
to
4e8773d
Compare
Fix nasa#393, update cfe_psp_module_findbyname and ...getAPIEntry to search internal module list.
avan989
force-pushed
the
fix-393-psp-find-module-by-name
branch
from
4e8773d
to
5d93e17
Compare
jphickey
approved these changes
Aug 17, 2023
dmknutsen
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 18, 2023
*Combines:* cFE v7.0.0-rc4+dev366 psp v1.6.0-rc4+dev82 **Includes:** *cFE* - nasa/cFE#2428 *psp* - nasa/PSP#397 - nasa/PSP#402 Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 18, 2023
*Combines:* cFE v7.0.0-rc4+dev366 psp v1.6.0-rc4+dev82 **Includes:** *cFE* - nasa/cFE#2428 *psp* - nasa/PSP#397 - nasa/PSP#402 Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to find psp module from standard list as well as global list
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Fixes #393. Since Linux Symon is part of the standard module, CFE_PSP_Module_FindByName and CFE_PSP_Module_GetAPIEntry also need to search the standard module list. This fix let these function iterate through CFE_PSP_BASE_MODULE_LIST as well as GLOBAL_CONFIGDATA.PspModuleList.
Testing performed
Steps taken to test the contribution:
Build with HS and linux sysmon as part of standard psp.
See the telemetry
Build with HS and Linux sysmon as part of the global psp list (add into target.cmake instead of standard psp)
See telemetry
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)
Anh Van. GSFC