Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #254, use CMake to publish interface details #255

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Mar 3, 2021

Describe the contribution
Use target_include_directories and target_compile_definitions to propagate the interface details for PSP

Fixes #254

Testing performed
Build and sanity check CFE, confirm building successfully

Expected behavior changes
None

System(s) tested on
Ubuntu 20.04

Additional context
This becomes required to support nasa/cFE#1203

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Use target_include_directories and target_compile_definitions to
propagate the interface details for PSP
@jphickey jphickey added build-system CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Mar 3, 2021
@astrogeco astrogeco added CCB:2021-03-03 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Mar 3, 2021
@astrogeco
Copy link
Contributor

CCB 2021-03-03 APPROVED

  • Helps future proof PSP for when we start relying on interface libraries

@skliper skliper added this to the 1.6.0 milestone Mar 5, 2021
@skliper skliper self-assigned this Mar 5, 2021
@skliper skliper merged commit e81fe5a into nasa:main Mar 5, 2021
@jphickey jphickey deleted the fix-254-psp-interface branch March 16, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PSP library to work with CMake interface logic
3 participants