Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #333, Relative strict-dir-list for static analysis workflow #334

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 8, 2022

Describe the contribution

Testing performed
Needs nasa/cFS#454 in main to actually test with CI

Expected behavior changes
Will work once nasa/cFS#454 is in

System(s) tested on
CI

Additional context
Depends on nasa/cFS#454, similar update as what's implemented in nasa/CF#228

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) dependency labels Apr 8, 2022
@skliper skliper added this to the Draco milestone Apr 8, 2022
@astrogeco astrogeco added CCB:Approved Indicates Approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 13, 2022
@astrogeco
Copy link
Contributor

CCB:2022-04-13 APPROVED

astrogeco added a commit that referenced this pull request Apr 18, 2022
Fix #333, Relative strict-dir-list for static analysis workflow
@astrogeco
Copy link
Contributor

astrogeco commented Apr 18, 2022

@skliper this seems to be failing even thouth nasa/cFS#454 is merged. See 55a575e I was able to make it pass by removing the / from the strict directory input

jobs:
  static-analysis:
    name: Run cppcheck
    uses: nasa/cFS/.github/workflows/static-analysis.yml@main
    with:
      strict-dir-list: 'fsw'

astrogeco added a commit that referenced this pull request Apr 18, 2022
Fix #333, Relative strict-dir-list for static analysis workflow

- HOTFIX #334, remove `./` prefix to fsw from strict-dir-list input
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 18, 2022
@astrogeco astrogeco merged commit 55a575e into nasa:main Apr 19, 2022
@skliper
Copy link
Contributor Author

skliper commented Apr 19, 2022

Just to follow up, the failure seems to have been due to just rerunning the failed job which didn't pull in the new reusable workflow. Then after removing the leading ./ the reusable workflow was pulled in. The ./ is really just there for readability (makes it obvious fsw is relative to the current directory), it works with or without.

astrogeco added a commit to astrogeco/PSP that referenced this pull request Apr 19, 2022
Dot-slash was removed erroneously. Including the `./` prefix increases awareness that the target directory is relative.
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 19, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 19, 2022
**Combines**

nasa/cFE#2091 v7.0.0-rc4+dev110

**Includes**

*cFE*

nasa/cFE#2077, Remove contributor license agreement

nasa/cFE#2085, Use reusable documentation generation workflow

nasa/cFE#2080, Add config module to coverage enforcemnt

nasa/cFE#2081, Improve ES unit test coverage

nasa/cFE#2082, Only increment SB InternalErrorCounter on errors

*osal*

nasa/osal#1246, Apply latest contributor license agreement links

*PSP*

nasa/PSP#331, Apply latest contributor license agreement links

nasa/PSP#334, Fix input to static analysis workflow

Co-authored-by: Jacob Hageman    <skliper@users.noreply.github.com>
Co-authored-by: Justing Figueroa <chillfigskliper@users.noreply.github.com>
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 19, 2022
**Combines**

nasa/cFE#2091 v7.0.0-rc4+dev110

**Includes**

*cFE*

nasa/cFE#2077, Remove contributor license agreement

nasa/cFE#2085, Use reusable documentation generation workflow

nasa/cFE#2080, Add config module to coverage enforcemnt

nasa/cFE#2081, Improve ES unit test coverage

nasa/cFE#2082, Only increment SB InternalErrorCounter on errors

*osal*

nasa/osal#1246, Apply latest contributor license agreement links

*PSP*

nasa/PSP#331, Apply latest contributor license agreement links

nasa/PSP#334, Fix input to static analysis workflow

Co-authored-by: Jacob Hageman    <skliper@users.noreply.github.com>
Co-authored-by: Justing Figueroa <chillfig@users.noreply.github.com>
@skliper skliper deleted the fix333-static_analysis branch April 19, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update static analysis workflow strict directory list for nasa/cFS#453
2 participants