Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #342, Resolve uninit var static analysis warning #344

Merged
merged 1 commit into from
May 31, 2022
Merged

Fix #342, Resolve uninit var static analysis warning #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions fsw/pc-linux/src/cfe_psp_start.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ int32 CFE_PSP_OS_EventHandler(OS_Event_t event, osal_id_t object_id, void *data)
{
char taskname[OS_MAX_API_NAME];

memset(taskname, 0, sizeof(taskname));

switch (event)
{
case OS_EVENT_RESOURCE_ALLOCATED:
Expand Down
8 changes: 8 additions & 0 deletions unit-test-coverage/modules/timebase_vxworks/src/coveragetest-timebase_vxworks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ void Test_Nominal(void)
OS_time_t OsTime;
PSP_VxWorks_TimeBaseVal_t VxTime;

memset(&OsTime, 0, sizeof(OsTime));

/* Nominal test with a simple 1:1 ratio */
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodNumerator = 1;
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodDenominator = 1;
Expand All @@ -103,6 +105,8 @@ void Test_Non_Reducible(void)
PSP_VxWorks_TimeBaseVal_t VxTime;
int64 TestTime;

memset(&OsTime, 0, sizeof(OsTime));

/* Use an oddball ratio of of some primes, will not be reducible */
/* Ratio is 43*3 / 53*2 => 129/106 */
/* This translates to about ~1.217ns per tick */
Expand Down Expand Up @@ -136,6 +140,8 @@ void Test_Reducible_1(void)
PSP_VxWorks_TimeBaseVal_t VxTime;
int64 TestTime;

memset(&OsTime, 0, sizeof(OsTime));

/* Test with a ratio that is also 1:1, but can be reduced */
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodNumerator = 1000;
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodDenominator = 1000;
Expand Down Expand Up @@ -164,6 +170,8 @@ void Test_Reducible_2(void)
PSP_VxWorks_TimeBaseVal_t VxTime;
int64 TestTime;

memset(&OsTime, 0, sizeof(OsTime));

/* Test with a ratio that can be reduced */
/* Final reduced ratio should be 12:5 with 100ns OS ticks */
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodNumerator = 84000;
Expand Down