Fix #385, adds generic driver interface and Linux sysmon module #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
jphickey
force-pushed
the
fix-385-sysmon
branch
2 times, most recently
from
3e1d254
to
cb99ae2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL-coding-standard found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
dzbaker
added
CCB: Provisionally-Approved
and removed
CCB:Ready
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
jphickey
force-pushed
the
fix-385-sysmon
branch
2 times, most recently
from
5f6e167
to
4bbc455
Compare
Defines an "iodriver" interface with a simple module id + opcode + argument interface, which can be extended as necessary for different purposes. Also adds a "linux_sysmon" module that implements this interface to provide system monitoring capabilities. This includes, but is not limited to, the CPU utilization that HS needs.
|
@dzbaker all issues have been cleaned up now, should be good to go. |
dzbaker
added
CCB:Approved
dzbaker
added a commit
that referenced
this pull request
Apr 10, 2023
Fix #385, adds generic driver interface and Linux sysmon module
2 tasks
Update the doxygen documentation to correct warnings, and correct some inconsistent symbol names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Defines an "iodriver" interface with a simple module id + opcode + argument interface, which can be extended as necessary for different purposes.
Also adds a "linux_sysmon" module that implements this interface to provide system monitoring capabilities. This includes, but is not limited to, the CPU utilization that HS needs.
Fixes #385
Testing performed
Build and run CFE with (patched) HS, observe CPU utilization getting reported correctly via the PSP module
Expected behavior changes
Adds "iodriver" pluggable/extendable interface, and "linux_sysmon" for health monitoring
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.