Inconsistent use of SC_LAST_RTS_WITH_EVENTS

[skliper]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
SC_LAST_RTS_WITH_EVENTS is documented like an index (1 based), but converted from 0 based in tests.

Documented as 1 based:

SC/config/default_sc_internal_cfg.h

Lines 139 to 142 in 29f7bad

	* \par Limits:
	* This parameter needs to be less than or equal to SC_NUMBER_OF_RTS
	*/
	#define SC_LAST_RTS_WITH_EVENTS 20

Verified as 1 based:

SC/fsw/src/sc_verify.h

Lines 108 to 114 in 29f7bad

	#ifndef SC_LAST_RTS_WITH_EVENTS
	#error SC_LAST_RTS_WITH_EVENTS must be defined!
	#elif (SC_LAST_RTS_WITH_EVENTS > SC_NUMBER_OF_RTS)
	#error SC_LAST_RTS_WITH_EVENTS cannot be greater than SC_NUMBER_OF_RTS!
	#elif (SC_LAST_RTS_WITH_EVENTS < 1)
	#error SC_LAST_RTS_WITH_EVENTS cannot be less than 1!
	#endif

Compared against 1 based number here:

SC/fsw/src/sc_rtsrq.c

Line 111 in 29f7bad

if (Cmd->Payload.RtsNum <= SC_LAST_RTS_WITH_EVENTS)

Correctly converted to an index here:

SC/unit-test/sc_state_tests.c

Line 453 in 29f7bad

SC_RtsIndex_t RtsIndex = SC_RTS_IDX_C(SC_LAST_RTS_WITH_EVENTS - 1);

Questionable use here since CFE_MSG_Init expects a size:

SC/unit-test/sc_state_tests.c

Line 471 in 29f7bad

CFE_MSG_Init((CFE_MSG_Message_t *)Entry, CFE_SB_ValueToMsgId(SC_CMD_MID), SC_LAST_RTS_WITH_EVENTS - 1);

BROKEN references here, used as 0 based:

SC/unit-test/sc_state_tests.c

Line 499 in 29f7bad

SC_RtsIndex_t RtsIndex = SC_RTS_IDX_C(SC_LAST_RTS_WITH_EVENTS);

SC/unit-test/sc_state_tests.c

Line 586 in 29f7bad

SC_RtsIndex_t RtsIndex = SC_RTS_IDX_C(SC_LAST_RTS_WITH_EVENTS);

These tests will probably fail if SC_LAST_RTS_WITH_EVENTS set to SC_NUMBER_OF_RTS - 1, should work correctly if 1 based.

SC/unit-test/sc_state_tests.c

Lines 788 to 794 in 29f7bad

	if (SC_LAST_RTS_WITH_EVENTS < SC_NUMBER_OF_RTS)
	{
	UtTest_Add(SC_GetNextRtsCommand_Test_ZeroCommandLengthLastRts, SC_Test_Setup, SC_Test_TearDown,
	"SC_GetNextRtsCommand_Test_ZeroCommandLengthLastRts");
	UtTest_Add(SC_GetNextRtsCommand_Test_EndOfBufferLastRts, SC_Test_Setup, SC_Test_TearDown,
	"SC_GetNextRtsCommand_Test_EndOfBufferLastRts");
	}

To Reproduce
Set SC_LAST_RTS_WITH_EVENTS to SC_NUMBER_OF_RTS as documented in the config header, fails at compile time
Note if set to SC_NUMBER_OF_RTS - 1, it doesn't look like it will report the last RTS events

Expected behavior
Setting SC_LAST_RTS_WITH_EVENTS to SC_NUMBER_OF_RTS should send event for all RTS's

Code snips
See above

System observed on:
all

Additional context
None

Reporter Info
Jacob Hageman/NASA GSFC

Ping @jphickey