Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OS_stat to verify file existence #5

Closed
skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #81
Closed

Use OS_stat to verify file existence #5

skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #81
Labels
enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

In SC_LoadDefaultTables, the OS_OpenCreate function is used to verify that a file can be opened before any attempt is made to load a table from it. Since the code as-is appears to only be checking for file existence (and not performing any validation on the files), code could be streamlined by using OS_stat.

Imported from GSFCCFS-1447
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Mar 21, 2023
@thnkslprpt
Fix nasa#5, Use OS_stat instead of OS_OpenCreate to verify file exist…
a2b7b30 
…ence
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Mar 21, 2023
@thnkslprpt
Fix nasa#5, Use OS_stat instead of OS_OpenCreate to verify file exist…
fae737a 
…ence
@thnkslprpt thnkslprpt mentioned this issue Mar 21, 2023
Merged
2 tasks
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Oct 2, 2023
@thnkslprpt
Fix nasa#5, Use OS_stat instead of OS_OpenCreate to verify file exist…
895d3fb 
…ence
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Jan 14, 2024
@thnkslprpt
Fix nasa#5, Use OS_stat instead of OS_OpenCreate to verify file exist…
95d63ac 
…ence
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Jan 14, 2024
@thnkslprpt
Fix nasa#5, Use OS_stat instead of OS_OpenCreate to verify file exist…
77b34c7 
…ence
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Jan 14, 2024
@thnkslprpt
Fix nasa#5, Use OS_stat instead of OS_OpenCreate to verify file exist…
00a7577 
…ence
dzbaker added a commit that referenced this issue Jan 25, 2024
@dzbaker
Merge pull request #81 from thnkslprpt/fix-5-convert-os-opencreate-to…
29f7bad 
…-os-stat

Fix #5, Remove `OS_OpenCreate` file status check in `SC_LoadDefaultTables`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5, Remove OS_OpenCreate file status check in SC_LoadDefaultTables thnkslprpt/SC
1 participant
@skliper