Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cES1007.3 and cES1008.3, reload/restart non-param error doesn't increment command err counter #1127

Closed
skliper opened this issue Jan 25, 2021 · 1 comment · Fixed by #1609
Assignees
Labels
docs This change only affects documentation. requirements
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Jan 25, 2021

Is your feature request related to a problem? Please describe.
Non-command parameter errors (errors within the object files) don't increment the command error counter since the command is processed as a request that happens later (takes time to execute)

cES1007.3: If the cFE Application Restart fails due to a non-parameter error, then the cFE shall delete the Application, increment the invalid Command counter, and generate an event message.
cES1008.3: If the cFE Application Reload fails due to a non-parameter error, then the cFE shall delete the Application, increment the invalid Command counter, and generate an event message.

Describe the solution you'd like
Update the requirements.

Describe alternatives you've considered
More complex command error handling (delay the success increment).

Additional context
#915

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the docs This change only affects documentation. label Jan 25, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 25, 2021
@skliper
Copy link
Contributor Author

skliper commented Jan 25, 2021

Also need to update cES1007.2 based on #1128, since it now checks for file existence before unloading app.

@skliper skliper self-assigned this Feb 1, 2021
skliper added a commit to skliper/cFE that referenced this issue Jun 7, 2021
…dates

 nasa#1205: Added task and CDS file write default filenames
 nasa#1131: Removed optional from EVS log
 nasa#1127: Non-parameter reload/restart doesn't increment cmd error
 nasa#1029: Removed system log elements from reset preservation list
 nasa#942: Simplifed table partial load file requirement
skliper added a commit to skliper/cFE that referenced this issue Jun 7, 2021
…dates

 nasa#1205: Added task and CDS file write default filenames
 nasa#1131: Removed optional from EVS log
 nasa#1127: Non-parameter reload/restart doesn't increment cmd error
 nasa#1029: Removed system log elements from reset preservation list
 nasa#942: Simplifed table partial load file requirement
astrogeco added a commit that referenced this issue Jun 15, 2021
@skliper skliper closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change only affects documentation. requirements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant