Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreatePipeErrorCounter only incremented for CFE_SB_CR_PIPE_BAD_ARG_EID or in CFE_SB_DeletePipeFull #1187

Closed
skliper opened this issue Feb 26, 2021 · 0 comments · Fixed by #1245 or #1258
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Feb 26, 2021

Is your feature request related to a problem? Please describe.
CreatePipeErrorCounter logic doesn't seem to make all that much sense since it's only incremented for one error case, and also incremented as part of deleting a pipe.

Note the trivial switch below is a static analysis warning, might be more appropriate to count warnings for more cases:

switch(PendingEventId)
{
case CFE_SB_CR_PIPE_BAD_ARG_EID:
++CFE_SB_Global.HKTlmMsg.Payload.CreatePipeErrorCounter;
break;
default:
/* no counter */
break;
}

Describe the solution you'd like
Trace design to requirements, confirm current implementation makes sense.

Describe alternatives you've considered
None

Additional context
Uncovered due to static analysis warning, any change will be easier after #972

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 7.0.0 milestone Feb 26, 2021
skliper added a commit to skliper/cFE that referenced this issue Mar 18, 2021
skliper added a commit to skliper/cFE that referenced this issue Mar 23, 2021
astrogeco added a commit that referenced this issue Mar 24, 2021
Fix #1187, Increment CreatePipeErrorCounter for all create pipe errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant