Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in test macro name: UtAssert_ResourceID_Undifeined #1291

Closed
jphickey opened this issue Apr 9, 2021 · 2 comments · Fixed by #1289 or #1431
Closed

Fix typo in test macro name: UtAssert_ResourceID_Undifeined #1291

jphickey opened this issue Apr 9, 2021 · 2 comments · Fixed by #1289 or #1431
Assignees
@zanzaben
Labels
unit-test
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented Apr 9, 2021

Describe the bug
Typo in recently added macro name:

cFE/modules/cfe_testcase/src/cfe_test.h

Line 52 in eaa343c

#define UtAssert_ResourceID_Undifeined(id) \

Expected behavior
"Undifeined" -> "Undefined"

Additional context
From #1251, which somehow got merged to main without fixing this

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@skliper skliper added this to the 7.0.0 milestone Apr 9, 2021
@zanzaben
Copy link
Contributor

zanzaben commented Apr 9, 2021

Will fix this in #1289

@jphickey
Copy link
Contributor Author

jphickey commented Apr 9, 2021

While you're at it, I would suggest the name CFE_Assert_ResourceId_Undefined() ... since this assert macro is part of the CFE-specific assert extensions, not the generic UtAssert.

zanzaben added a commit to zanzaben/cFE that referenced this issue Apr 22, 2021
@zanzaben
Fix nasa#809, add ES Child Task Functional Test
4c5b215 
Fix nasa#1291, fix spelling typo
@zanzaben zanzaben mentioned this issue Apr 22, 2021
Merged
zanzaben added a commit to zanzaben/cFE that referenced this issue Apr 22, 2021
@zanzaben
Fix nasa#809, add ES Child Task Functional Test
d785db8 
Fix nasa#1291, fix spelling typo
@astrogeco astrogeco changed the title Fix typo in test macro name Fix typo in test macro name: UtAssert_ResourceID_Undifeined(id) Apr 28, 2021
@astrogeco astrogeco changed the title Fix typo in test macro name: UtAssert_ResourceID_Undifeined(id) Fix typo in test macro name: UtAssert_ResourceID_Undifeined Apr 28, 2021
@astrogeco astrogeco mentioned this issue Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
unit-test
Projects
None yet
Milestone
Caelum
3 participants
@zanzaben @jphickey @skliper