Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extern from function prototypes #1319

Closed
skliper opened this issue Apr 13, 2021 · 4 comments · Fixed by #1908
Closed

Remove extern from function prototypes #1319

skliper opened this issue Apr 13, 2021 · 4 comments · Fixed by #1908
Labels
CFS-40 CFS-41 CFS-42 draco-rc1 enhancement good first issue Good for newcomers
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
Inconsistently applying extern to function prototypes

Describe the solution you'd like
Remove, it makes no difference.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@himanshu007-creator
Copy link
Contributor

I would like to work on this issue. Please guide me further

@skliper skliper added the CFS-40 label Apr 13, 2021
@skliper skliper added the CFS-41 label Apr 20, 2021
@skliper skliper added the CFS-42 label Apr 29, 2021
@skliper skliper mentioned this issue May 11, 2021
Closed
paulober pushed a commit to paulober/cFE that referenced this issue Aug 28, 2021
Fix nasa#1319, Remove extern from function prototypes
71470bc
paulober pushed a commit to paulober/cFE that referenced this issue Aug 28, 2021
Fix nasa#1319, Remove extern from function prototypes
3906ccc
@paulober paulober mentioned this issue Aug 28, 2021
Merged
@paulober
Copy link
Contributor

@skliper

I have removed all extern from all function prototypes in the project. Could this cause unforeseen problems (in conjunction with the cFS)?

@skliper
Copy link
Contributor Author

skliper commented Aug 30, 2021

Not for the function prototypes, declaring as extern has no impact since it's the default. https://stackoverflow.com/questions/27447285/extern-on-function-prototypes. Thanks for the contribution!

@paulober
Copy link
Contributor

Ok, great to know.

@skliper skliper mentioned this issue Aug 30, 2021
Closed
@astrogeco astrogeco added this to the cFS-Draco milestone Aug 30, 2021
astrogeco added a commit to astrogeco/cFE that referenced this issue Nov 3, 2021
@astrogeco
Merge pull request nasa#1908 from pavll/fix-1319-remove-extern-from-f…
c8779ca 
…unction-protos

Fix nasa#1319, Remove extern from function prototypes
astrogeco pushed a commit to astrogeco/cFE that referenced this issue Nov 3, 2021
@astrogeco
Fix nasa#1319, Remove extern from function prototypes
795bd91 
Co-authored by: Gerardo E. Cruz-Ortiz <59618057+astrogeco@users.noreply.github.com>
astrogeco added a commit to astrogeco/cFE that referenced this issue Nov 3, 2021
@astrogeco
Merge pull request nasa#1908 from pavll/fix-1319-remove-extern-from-f…
7839aae 
…unction-protos

Fix nasa#1319, Remove extern from function prototypes

Re-adds externs removed from CFE_ES_ObjectTable and CFE_ES_Global to
fix RTEMS build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-40 CFS-41 CFS-42 draco-rc1 enhancement good first issue Good for newcomers
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #1319, Remove extern from function prototypes paulober/cFE
4 participants
@paulober @skliper @astrogeco @himanshu007-creator