Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_ES_ClearCDS: check status before while loop to zero #1338

Closed
skliper opened this issue Apr 13, 2021 · 0 comments · Fixed by #1373 or #1431
Closed

CFE_ES_ClearCDS: check status before while loop to zero #1338

skliper opened this issue Apr 13, 2021 · 0 comments · Fixed by #1373 or #1431
Assignees
@jphickey
Labels
CFS-40 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
Status not checked from CFE_ES_CDS_CachePreload:

cFE/modules/es/fsw/src/cfe_es_cds.c

Line 534 in e80aae9

Status = CFE_ES_CDS_CachePreload(&CDS->Cache, NULL, 0, sizeof(CDS->Cache.Data.Zero));

Describe the solution you'd like
Analyze, check status if needed otherwise document why not for future reference

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 13, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Apr 16, 2021
@jphickey
Fix nasa#1338, check status of call to CFE_ES_CDS_CachePreload
624d586 
Confirm that the call returned CFE_SUCCESS before continuing.
@jphickey jphickey mentioned this issue Apr 16, 2021
Merged
jphickey added a commit to jphickey/cFE that referenced this issue Apr 20, 2021
@jphickey
Fix nasa#1338, ignore status of call to CFE_ES_CDS_CachePreload
85bfba2 
The function cannot fail in this context
astrogeco added a commit that referenced this issue Apr 28, 2021
@astrogeco
Merge pull request #1373 from jphickey/fix-1338-check-status
069646d 
Fix #1338, check status of call to CFE_ES_CDS_CachePreload
@astrogeco astrogeco mentioned this issue Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
CFS-40 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper