Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overloaded "PacketID" use in CFE_EVS_PacketID #1397

Open
skliper opened this issue Apr 20, 2021 · 2 comments · May be fixed by #2348
Open

Overloaded "PacketID" use in CFE_EVS_PacketID #1397

skliper opened this issue Apr 20, 2021 · 2 comments · May be fixed by #2348
Labels
CFS-41 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Apr 20, 2021

Is your feature request related to a problem? Please describe.
PacketID means other things so it's a bit confusing in this context.

Describe the solution you'd like
Could be Signature, PktIdentity, EventSignature, EventContext, Context... suggest your own!

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 20, 2021
@skliper skliper changed the title Overloaded PacketID use in CFE_EVS_PacketID Overloaded "PacketID use in CFE_EVS_PacketID Apr 20, 2021
@skliper skliper changed the title Overloaded "PacketID use in CFE_EVS_PacketID Overloaded "PacketID" use in CFE_EVS_PacketID Apr 20, 2021
@astrogeco astrogeco mentioned this issue Apr 21, 2021
Closed
@skliper
Copy link
Contributor Author

skliper commented Apr 21, 2021

Event Metadata.

@skliper skliper removed this from the 7.0.0 milestone May 17, 2021
@thnkslprpt
Copy link
Contributor

+1 vote for EventContext

thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue May 24, 2023
@thnkslprpt
Fix nasa#1397, Rename overloaded EVS_PacketID_t to `EVS_EventContex…
329aff4 
…t_t`
@thnkslprpt thnkslprpt linked a pull request May 24, 2023 that will close this issue
Open
2 tasks
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Dec 3, 2023
@thnkslprpt
Fix nasa#1397, Rename overloaded EVS_PacketID_t to `EVS_EventContex…
658c84e 
…t_t`
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Dec 3, 2023
@thnkslprpt
Fix nasa#1397, Rename overloaded EVS_PacketID_t to `EVS_EventContex…
4cc2a65 
…t_t`
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Dec 14, 2023
@thnkslprpt
Fix nasa#1397, Rename overloaded EVS_PacketID_t to `EVS_EventContex…
c6553fc 
…t_t`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-41 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1397, Rename overloaded EVS_PacketID_t to EVS_EventContext_t thnkslprpt/cFE
2 participants
@thnkslprpt @skliper